Skip to content

[WIP] non-nullable amount in confirm_ethereum_tx#6836

Closed
ibz wants to merge 1 commit into
mainfrom
ibz/eth-hide-zero-amount
Closed

[WIP] non-nullable amount in confirm_ethereum_tx#6836
ibz wants to merge 1 commit into
mainfrom
ibz/eth-hide-zero-amount

Conversation

@ibz

@ibz ibz commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3cc5e196-d4ed-4edc-a06a-e401dd604ceb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ibz/eth-hide-zero-amount

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware Apr 27, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Apr 27, 2026
@github-actions

github-actions Bot commented Apr 27, 2026

Copy link
Copy Markdown

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 24994780832

@ibz ibz force-pushed the ibz/eth-hide-zero-amount branch from 74d7bfa to da3de9c Compare April 27, 2026 12:20
@ibz ibz force-pushed the ibz/eth-hide-zero-amount branch from da3de9c to 3a4b7f3 Compare April 27, 2026 12:23
@ibz ibz changed the title WIP [WIP] non-nullable amount in confirm_ethereum_tx Apr 27, 2026
@ibz ibz closed this May 1, 2026
@trezor-bot trezor-bot Bot moved this from 🔎 Needs review to ✅ Done (no QA) in Firmware May 1, 2026
@ibz ibz deleted the ibz/eth-hide-zero-amount branch June 4, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done (no QA)

Development

Successfully merging this pull request may close these issues.

1 participant