chore(core): return N4W1 in Features.capabilities#6841
Conversation
[no changelog]
WalkthroughThis change introduces a new device capability identifier Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3B1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3W1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
Latest CI run: 25006683765
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@core/src/apps/base.py`:
- Around line 165-167: get_features() currently appends Capability.N4W1 when
utils.USE_N4W1 is true, but this can advertise N4W1 in universal builds; change
the guard so Capability.N4W1 is only appended when both utils.USE_N4W1 and the
bitcoin-only build flag are true (e.g., check utils.BITCOIN_ONLY or equivalent
build flag alongside utils.USE_N4W1) where the append to f.capabilities (the
f.capabilities.append(Capability.N4W1) call) occurs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 039da179-4365-4792-9a62-2b8c120758c9
⛔ Files ignored due to path filters (1)
rust/trezor-client/src/protos/generated/messages_management.rsis excluded by!**/generated/**
📒 Files selected for processing (5)
common/protob/messages-management.protocore/src/apps/base.pycore/src/trezor/enums/Capability.pycore/src/trezor/enums/__init__.pypython/src/trezorlib/messages.py




































Will be used to detect N4W1-enabled builds.