Skip to content

chore(ci): update create-github-app-token to suport Node.js 24#6846

Merged
Thalarion merged 1 commit into
mainfrom
thalarion/fix_nodejs_20_warning_in_crowdin_pull
May 6, 2026
Merged

chore(ci): update create-github-app-token to suport Node.js 24#6846
Thalarion merged 1 commit into
mainfrom
thalarion/fix_nodejs_20_warning_in_crowdin_pull

Conversation

@Thalarion

@Thalarion Thalarion commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

See
image
here
https://github.com/trezor/trezor-firmware/actions/runs/24768702531

I tested Crowdin - pull translations (manual) action and it worked as expected.

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 53b09df9-9007-4ca0-8977-b74efa3ff88a

📥 Commits

Reviewing files that changed from the base of the PR and between 07f456f and 8d4dace.

📒 Files selected for processing (4)
  • .github/workflows/bot-common-sync.yml
  • .github/workflows/bot-needs-qa.yml
  • .github/workflows/bot-project-automation.yml
  • .github/workflows/crowdin-pull.yml
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/bot-project-automation.yml
  • .github/workflows/bot-needs-qa.yml

Walkthrough

Four GitHub Actions workflows (.github/workflows/{bot-common-sync, bot-needs-qa, bot-project-automation, crowdin-pull}.yml) update the "Generate GitHub App token" step to a pinned v3.1.1 revision of actions/create-github-app-token (specific commit). The step input key is changed from app-id to client-id and now references TREZOR_BOT_CLIENT_ID where applicable; private-key continues to use TREZOR_BOT_PRIVATE_KEY. No other workflow logic, outputs, or exported/public entities were modified.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete and lacks required sections from the template. It does not follow the structured format for core developers, missing PR setup details, development status assignment, and post-merge status. Add PR assignment, project setup details, and status information as outlined in the template. Include whether testing is required and add 'Notes for QA' if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the create-github-app-token action to support Node.js 24, which aligns with the changeset updating the action version across multiple workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thalarion/fix_nodejs_20_warning_in_crowdin_pull

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware Apr 28, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Apr 28, 2026
@Thalarion Thalarion added the ci Continuous Integration (CI) related label Apr 28, 2026
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 25424291564

@Thalarion Thalarion changed the title chore(ci): create-github-app-token to suport Node.js 24 chore(ci): update create-github-app-token to suport Node.js 24 Apr 28, 2026
@Thalarion Thalarion force-pushed the thalarion/fix_nodejs_20_warning_in_crowdin_pull branch 2 times, most recently from 476a242 to 2916a86 Compare April 28, 2026 20:16
@Thalarion Thalarion requested a review from M1nd3r April 28, 2026 20:18
@Thalarion Thalarion marked this pull request as ready for review April 28, 2026 20:19

@M1nd3r M1nd3r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The commit hashes are valid and expected.
  • I was not able to verify, whether the secret TREZOR_BOT_APP_ID is of type client-id.

nit:
Consider being more verbose in commit messages - e.g. specifying from-to versions when updating something and using the actual name of what you are updating. (example)

Comment thread .github/workflows/bot-common-sync.yml Outdated
Comment thread .github/workflows/bot-common-sync.yml Outdated
@github-project-automation github-project-automation Bot moved this from 🔎 Needs review to 🏃‍♀️ In progress in Firmware May 5, 2026

@M1nd3r M1nd3r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Thalarion Thalarion force-pushed the thalarion/fix_nodejs_20_warning_in_crowdin_pull branch from 07f456f to 8d4dace Compare May 6, 2026 08:20
@Thalarion

Copy link
Copy Markdown
Contributor Author

successful test run, with the new TREZOR_BOT_CLIENT_ID, here

@Thalarion Thalarion merged commit 0ff0c52 into main May 6, 2026
109 checks passed
@Thalarion Thalarion deleted the thalarion/fix_nodejs_20_warning_in_crowdin_pull branch May 6, 2026 09:15
@trezor-bot trezor-bot Bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Firmware May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration (CI) related

Projects

Status: 🤝 Needs QA

Development

Successfully merging this pull request may close these issues.

3 participants