Cleanup ERC-7730 type names

[ibz]

Small follow-up for #6748 to make message names nicer.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4d2d5206-709e-4cb9-b992-438cc0af932b

📥 Commits

Reviewing files that changed from the base of the PR and between 0fb7607 and 0f0550d.

⛔ Files ignored due to path filters (1)

• rust/trezor-client/src/protos/generated/messages_definitions.rs is excluded by !**/generated/**

📒 Files selected for processing (11)

• common/protob/messages-definitions.proto
• core/src/apps/common/definitions.py
• core/src/apps/ethereum/clear_signing.py
• core/src/trezor/enums/DefinitionType.py
• core/src/trezor/enums/__init__.py
• core/src/trezor/messages.py
• legacy/firmware/protob/Makefile
• python/src/trezorlib/messages.py
• tests/definitions.py
• tests/device_tests/ethereum/test_definitions.py
• tests/device_tests/ethereum/test_definitions_bad.py

✅ Files skipped from review due to trivial changes (4)

• core/src/trezor/enums/init.py
• tests/device_tests/ethereum/test_definitions.py
• core/src/trezor/enums/DefinitionType.py
• tests/definitions.py

🚧 Files skipped from review as they are similar to previous changes (6)

• core/src/apps/ethereum/clear_signing.py
• legacy/firmware/protob/Makefile
• python/src/trezorlib/messages.py
• tests/device_tests/ethereum/test_definitions_bad.py
• core/src/trezor/messages.py
• core/src/apps/common/definitions.py

---

Walkthrough

This pull request generalizes the naming of an Ethereum display format from an ERC-7730-specific designation to a more generic convention. The protobuf message type EthereumERC7730DisplayFormatInfo is renamed to EthereumDisplayFormatInfo, and the corresponding enum value ETHEREUM_ERC7730_DISPLAY_FORMAT is renamed to ETHEREUM_DISPLAY_FORMAT. The numeric identifier (value 3) and all field structures remain unchanged. This naming update is propagated across the proto definition, Python code in both core and legacy implementations, Python library exports, test utilities, and test files to maintain consistency throughout the codebase.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Cleanup ERC-7730 type names' accurately summarizes the main change: renaming ERC-7730-specific type identifiers to generic Ethereum display format names across the codebase.
Description check	✅ Passed	The PR description references issue #6748 and explains the purpose as a cleanup to improve message naming, which aligns with the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ibz/cleanup-erc7730-name

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

en main(all)

model	device_test	click_test	persistence_test
T2T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)	test(all) main(all)

Latest CI run: 25095441422