Skip to content

build(core): add #![warn(clippy::cast_lossless)]#6849

Draft
romanz wants to merge 2 commits into
mainfrom
romanz/2604/clippy-cast
Draft

build(core): add #![warn(clippy::cast_lossless)]#6849
romanz wants to merge 2 commits into
mainfrom
romanz/2604/clippy-cast

Conversation

@romanz

@romanz romanz commented Apr 29, 2026

Copy link
Copy Markdown
Contributor
warning: `trezor_lib` (lib) generated 253 warnings (run `cargo clippy --fix --lib -p trezor_lib -- ` to apply 233 suggestions)

https://github.com/trezor/trezor-firmware/actions/runs/25099514846/job/73545397242?pr=6849#step:6:3675

@trezor-bot trezor-bot Bot added this to Firmware Apr 29, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Apr 29, 2026
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b6041a79-31b0-40dd-8d38-700010d11235

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch romanz/2604/clippy-cast

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 25373762654

@romanz romanz added the no-QA On PR-merge, automatically transition status in the "Firmware" project to "Done (no QA)" state. label Apr 29, 2026
@mmilata

mmilata commented May 5, 2026

Copy link
Copy Markdown
Member

Pushed the result of cargo clippy --fix. Warnings remain for trezorhal.rs (generated) and lerp.rs, we can either add exceptions or just treat it as one time fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-QA On PR-merge, automatically transition status in the "Firmware" project to "Done (no QA)" state.

Projects

Status: 🔎 Needs review

Development

Successfully merging this pull request may close these issues.

2 participants