Remove unused monero hasher

[M1nd3r]

Removal of unused code in monero.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a2668d30-526f-4d4f-a762-0085256b226b

📥 Commits

Reviewing files that changed from the base of the PR and between b87c1fd and 20c5ee7.

⛔ Files ignored due to path filters (1)

• core/mocks/generated/trezorcrypto/monero.pyi is excluded by !**/generated/**

📒 Files selected for processing (5)

• core/embed/upymod/modtrezorcrypto/modtrezorcrypto-monero.h
• crypto/monero/xmr.c
• crypto/monero/xmr.h
• crypto/tests/test_check.c
• crypto/tests/test_check_monero.h

💤 Files with no reviewable changes (5)

• crypto/monero/xmr.h
• crypto/monero/xmr.c
• crypto/tests/test_check.c
• core/embed/upymod/modtrezorcrypto/modtrezorcrypto-monero.h
• crypto/tests/test_check_monero.h

---

Walkthrough

The incremental Monero hasher API and its MicroPython binding were removed. The MicroPython Hasher type (constructor, update, digest, copy, destructor, block_size, digest_size) was deleted from core/embed/upymod/modtrezorcrypto/modtrezorcrypto-monero.h. Corresponding wrapper functions (xmr_hasher_init, xmr_hasher_update, xmr_hasher_final, xmr_hasher_copy) were removed from crypto/monero/xmr.c and their declarations dropped from crypto/monero/xmr.h. The unit test covering the incremental hasher was removed from the test suite.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description is minimal and lacks required template sections like development status, project assignment, and QA information specified in the template.	Add required sections from the template including development status (Draft/Needs Review), project assignment, priority, and QA notes as indicated by the 'no-QA' label.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately summarizes the main change: removal of unused monero hasher code across multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch m1nd3r/remove-unused-hasher

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

en main(all)

model	device_test	click_test	persistence_test
T2T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)	test(all) main(all)

Latest CI run: 25120657472

[obrusvit]

The best code is no code.