Skip to content

chore: remove unused code in theme#6865

Merged
obrusvit merged 1 commit into
mainfrom
obrusvit/rm-dead-code
May 3, 2026
Merged

chore: remove unused code in theme#6865
obrusvit merged 1 commit into
mainfrom
obrusvit/rm-dead-code

Conversation

@obrusvit

@obrusvit obrusvit commented May 3, 2026

Copy link
Copy Markdown
Contributor

Should have been done in b526466

@obrusvit obrusvit requested a review from romanz May 3, 2026 11:06
@obrusvit obrusvit self-assigned this May 3, 2026
Copilot AI review requested due to automatic review settings May 3, 2026 11:06
@trezor-bot trezor-bot Bot added this to Firmware May 3, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware May 3, 2026
@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 73e317a8-2d66-4fdc-9a08-2983ec67107c

📥 Commits

Reviewing files that changed from the base of the PR and between ca60997 and 6d5e3c8.

📒 Files selected for processing (2)
  • core/embed/rust/src/ui/layout_bolt/theme/mod.rs
  • core/embed/rust/src/ui/layout_delizia/theme/mod.rs
💤 Files with no reviewable changes (1)
  • core/embed/rust/src/ui/layout_bolt/theme/mod.rs

Walkthrough

Two theme modules (bolt and delizia) have their borders_notification() helper function removed. This function previously provided standardized inset values for notification borders. The bolt variant returned Insets::new(48, 6, 6, 6) while the delizia variant returned Insets::new(42, 0, 0, 0). Additionally, the delizia module's import statement was simplified by removing the now-unused Insets type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description lacks substantive detail beyond a reference to a previous commit; it mostly contains the repository template without addressing what was removed or why. Add specific details about which functions were removed and from which files to clarify the scope of this chore.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing unused borders_notification() functions from two theme modules.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch obrusvit/rm-dead-code

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 25277470780

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused theme helpers from the Delizia and Bolt UI layouts to simplify the theme modules and eliminate dead code.

Changes:

  • Removed unused borders_notification() from layout_delizia theme (and dropped now-unused Insets import).
  • Removed unused borders_notification() from layout_bolt theme.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/embed/rust/src/ui/layout_delizia/theme/mod.rs Drops unused notification border helper and its unused Insets import.
core/embed/rust/src/ui/layout_bolt/theme/mod.rs Drops unused notification border helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@obrusvit obrusvit merged commit 108189e into main May 3, 2026
112 checks passed
@obrusvit obrusvit deleted the obrusvit/rm-dead-code branch May 3, 2026 12:54
@trezor-bot trezor-bot Bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware May 3, 2026
@obrusvit obrusvit moved this from 🤝 Needs QA to ✅ Done (no QA) in Firmware May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done (no QA)

Development

Successfully merging this pull request may close these issues.

3 participants