fix(core): improve stellar confirmation screens

[PrisionMike]

fixes #6709
Cherry-picking from #6771
CC @overcat

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)

• tests/ui_tests/fixtures.json

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f87b6448-062e-492e-b877-42f34d8936c7

📥 Commits

Reviewing files that changed from the base of the PR and between 284c6ac and ca22c7f.

📒 Files selected for processing (1)

• tests/ui_tests/fixtures.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

This PR refactors Stellar transaction confirmation flows to improve visual clarity between intermediate and final confirmation screens. The changes introduce a new confirm_stellar_output_amount helper function across all UI frameworks (bolt, caesar, delizia, eckhart) and make confirm_stellar_output signature flexible with optional parameters. The Stellar app layer (layout.py and operations/layout.py) is updated to use these new helpers consistently and add explicit verb=TR.buttons__continue parameters throughout operation confirmations to clarify button behavior at each step.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The PR description is minimal and lacks required template sections for core developers, particularly missing project assignment, priority, team, sprint, and development status information.	Add comprehensive PR description following the template: assign yourself, add to Firmware project with Priority/Team/Sprint, and set development status to 'Needs Review' since this appears ready for review rather than a draft.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(core): improve stellar confirmation screens' clearly summarizes the main change - improving Stellar confirmation screens UI.
Linked Issues check	✅ Passed	The PR addresses issue #6709 by refactoring Stellar confirmation screens to use improved UI helpers and explicit continue verbs, differentiating intermediate confirmations from final confirmations.
Out of Scope Changes check	✅ Passed	All changes are directly related to improving Stellar confirmation screens as specified in issue #6709 and involve layout refactoring and UI helper updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch overcat/fix-stellar-layout

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

en main(all)

model	device_test	click_test	persistence_test
T2T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)	test(all) main(all)

Translations

cs main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

de main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

es main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

fr main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

pt main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

Latest CI run: 25805954837

[obrusvit]

LGTM, two comments.

[obrusvit]

Let's shorten it to something like: "Improve Stellar confirmations flows."

[obrusvit]

If it must be supplied together, please make the function take the type enforcing it, i.e. amount: (str, StellarAsset) | None.

Double-check similar pattern in other function calls please.

[obrusvit]

@copilot create a new branch from this one and implement the feedback of this comment. Then create another PR targeting the base branch.

[Copilot]

@obrusvit I've opened a new pull request, #6942, to work on those changes. Once the pull request is ready, I'll request review from you.