chore(translations): updates to English strings#6928
Conversation
Thalarion
commented
May 14, 2026
- mainly adding periods where approprite for Delizia and Eckhart [no changelog]
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Hidden review stack artifactWalkthroughThis PR updates translation strings across two files to improve punctuation consistency and support device-specific message variants. The type stub file (core/mocks/trezortranslate_keys.pyi) is updated to reflect changes in the source translation file (core/translations/en.json). Changes include adding trailing periods to six status and confirmation messages (backup completion, brightness change, wallet recovery, share completion, and transaction signing) for Delizia/Eckhart display variants. Two translation entries (ethereum__approve_unlimited_template and language__changed) are restructured from single strings to per-device objects with device-specific punctuation and formatting. The tutorial menu text is adjusted to change ellipsis formatting from "quit flow, ..." to "quit flow...". Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
087b088 to
449c970
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core/translations/en.json`:
- Around line 320-325: The Eckhart variant for the "brightness__changed_title"
translation is empty while Delizia contains "Display brightness changed.";
update the Eckhart entry to match Delizia (set "Eckhart": "Display brightness
changed.") unless the empty value is intentional—locate the
"brightness__changed_title" object in core/translations/en.json and add the same
sentence (including the trailing period) to the Eckhart key for consistency with
other entries like "backup__title_backup_completed" and "language__changed".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5f2e5f76-3f44-4ea1-87d3-4c1c8911f476
⛔ Files ignored due to path filters (1)
core/embed/rust/src/translations/generated/translated_string.rsis excluded by!**/generated/**
📒 Files selected for processing (3)
core/mocks/trezortranslate_keys.pyicore/translations/en.jsontests/ui_tests/fixtures.json
- mainly adding periods where approprite for Delizia and Eckhart [no changelog]
449c970 to
18b29fe
Compare



























































































































































