Skip to content

chore(translations): updates to English strings#6928

Merged
Thalarion merged 1 commit into
mainfrom
thalarion/260514_english_localization_improvements
May 15, 2026
Merged

chore(translations): updates to English strings#6928
Thalarion merged 1 commit into
mainfrom
thalarion/260514_english_localization_improvements

Conversation

@Thalarion
Copy link
Copy Markdown
Contributor

  • mainly adding periods where approprite for Delizia and Eckhart [no changelog]

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d675c37-37e6-4991-a0d0-2bc9b3c1880a

📥 Commits

Reviewing files that changed from the base of the PR and between 449c970 and 18b29fe.

⛔ Files ignored due to path filters (1)
  • core/embed/rust/src/translations/generated/translated_string.rs is excluded by !**/generated/**
📒 Files selected for processing (3)
  • core/mocks/trezortranslate_keys.pyi
  • core/translations/en.json
  • tests/ui_tests/fixtures.json
✅ Files skipped from review due to trivial changes (1)
  • core/mocks/trezortranslate_keys.pyi
🚧 Files skipped from review as they are similar to previous changes (1)
  • core/translations/en.json

Hidden review stack artifact

Walkthrough

This PR updates translation strings across two files to improve punctuation consistency and support device-specific message variants. The type stub file (core/mocks/trezortranslate_keys.pyi) is updated to reflect changes in the source translation file (core/translations/en.json). Changes include adding trailing periods to six status and confirmation messages (backup completion, brightness change, wallet recovery, share completion, and transaction signing) for Delizia/Eckhart display variants. Two translation entries (ethereum__approve_unlimited_template and language__changed) are restructured from single strings to per-device objects with device-specific punctuation and formatting. The tutorial menu text is adjusted to change ellipsis formatting from "quit flow, ..." to "quit flow...".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore(translations): updates to English strings' accurately describes the main changes—adding periods to English translation strings for specific device models.
Description check ✅ Passed The description briefly explains the main change (adding periods for Delizia and Eckhart) and notes no changelog, but lacks PR setup details expected for core developers per the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thalarion/260514_english_localization_improvements

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware May 14, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware May 14, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 25925722310

@Thalarion Thalarion force-pushed the thalarion/260514_english_localization_improvements branch 4 times, most recently from 087b088 to 449c970 Compare May 15, 2026 12:37
@Thalarion Thalarion requested a review from romanz May 15, 2026 12:38
@Thalarion Thalarion marked this pull request as ready for review May 15, 2026 13:38
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@core/translations/en.json`:
- Around line 320-325: The Eckhart variant for the "brightness__changed_title"
translation is empty while Delizia contains "Display brightness changed.";
update the Eckhart entry to match Delizia (set "Eckhart": "Display brightness
changed.") unless the empty value is intentional—locate the
"brightness__changed_title" object in core/translations/en.json and add the same
sentence (including the trailing period) to the Eckhart key for consistency with
other entries like "backup__title_backup_completed" and "language__changed".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5f2e5f76-3f44-4ea1-87d3-4c1c8911f476

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27d5d and 449c970.

⛔ Files ignored due to path filters (1)
  • core/embed/rust/src/translations/generated/translated_string.rs is excluded by !**/generated/**
📒 Files selected for processing (3)
  • core/mocks/trezortranslate_keys.pyi
  • core/translations/en.json
  • tests/ui_tests/fixtures.json

Comment thread core/translations/en.json
@Thalarion Thalarion added the translations Put this label on a PR to run tests in all languages label May 15, 2026
- mainly adding periods where approprite for Delizia and Eckhart
[no changelog]
@Thalarion Thalarion force-pushed the thalarion/260514_english_localization_improvements branch from 449c970 to 18b29fe Compare May 15, 2026 15:18
@Thalarion Thalarion merged commit 26f0f85 into main May 15, 2026
170 checks passed
@Thalarion Thalarion deleted the thalarion/260514_english_localization_improvements branch May 15, 2026 19:39
@trezor-bot trezor-bot Bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware May 15, 2026
@Thalarion Thalarion moved this from 🤝 Needs QA to ✅ Done (no QA) in Firmware May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translations Put this label on a PR to run tests in all languages

Projects

Status: ✅ Done (no QA)

Development

Successfully merging this pull request may close these issues.

2 participants