Feat/thp transport prerequisite #19122
Conversation
szymonlesisz
requested review from
mroz22,
martykan and
marekrjpolak
as code owners
szymonlesisz
added
connect
szymonlesisz
force-pushed
the
feat/thp-transport-prerequisite
branch
from
312effa to
3ae03c6
Compare
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
szymonlesisz
force-pushed
the
feat/thp-transport-prerequisite
branch
from
3ae03c6 to
830a081
Compare
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
szymonlesisz
force-pushed
the
feat/thp-transport-prerequisite
branch
from
830a081 to
68888c9
Compare
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
| private _protocol: TransportProtocol; | ||
| public get protocol() { | ||
| return this._protocol; | ||
| } |
There was a problem hiding this comment.
btw is this better then simply accessing public readonly protocol?
There was a problem hiding this comment.
idk. i had it as public then i decided to adjust to the rest of the code
| } else if (wasUnacquired && this.isUnacquired() && this.thp?.properties) { | ||
| this.emitLifecycle(DEVICE.CONNECT_UNACQUIRED); |
There was a problem hiding this comment.
It would be nice if @marekrjpolak could check this line.
There was a problem hiding this comment.
actually thanks for noticing, it does not belong to this PR i will add it later with some more context to it
- ThpState as params of send/receive/call functions - union of protobuf Messages.MessageResponse + ThpMessageResponse;
…ntSession - use `protocol` from this.device, the value is dynamic and could be changed after DeviceCurrentSession is created - add `thpState` to transport call/send/receive
szymonlesisz
force-pushed
the
feat/thp-transport-prerequisite
branch
from
68888c9 to
0c80213
Compare
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
|
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
Description
based on #19073, ignore first two commitsfeat(protocol): add THP protobuf definitions and types
protobuf messages are not merged in the firmware repo yet but i think we can have them here, im sure they will not change significantly.
The comment claims it was build by protobuf script which is missing in here, i will add it later once protobuf is merged into main to avoid protobuf build problems
add
ThpStateandThpMessageResponseto transport api@trezor/connecttyped call)feat(transport-bridge) accept protocol-v2 (THP) messages
Just a preparation for the bridge to accept additional params (protocol)
feat(connect): add
ThpStateandThpMessageResponseto DeviceCurrentSessionprotocolfrom this.device, the value is dynamic and could be changed after DeviceCurrentSession is createdthpStateto transport call/send/receiveMessageResponse(union of protobuf and thp) instead ofMessages.MessageResponse(protobuf only)🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents