fix(e2e-reporter): fixes reporter conditional start #21318
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a conditional logic issue in the e2e test reporter that was causing reports to be published unintentionally. The fix simplifies the reporter triggering logic and ensures proper control over when test results are published to GitHub.
- Simplifies the reporter conditional logic by removing the
github.event_name == 'workflow_call'condition - Standardizes input definitions by adding missing
type: booleandeclarations - Updates orchestration workflow to explicitly pass
publishResultsToGitHub: truewhen calling reusable workflows
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/tests/e2e-github-reporter.md | Removes outdated documentation about the old conditional logic |
| .github/workflows/test-suite-web-e2e-release.yml | Adds input definition for workflow_call and simplifies run-reporter condition |
| .github/workflows/test-suite-release-e2e-report-orchestration.yml | Explicitly passes publishResultsToGitHub: true to called workflows |
| .github/workflows/test-suite-native-e2e-android.yml | Adds type: boolean and passes input as secret |
| .github/workflows/test-suite-native-e2e-android-t3w1.yml | Adds type: boolean and passes input as secret |
| .github/workflows/test-suite-desktop-e2e-release.yml | Adds input definition for workflow_call and simplifies run-reporter condition |
| e2e-passphrase: ${{ secrets.E2E_TEST_PASSPHRASE }} | ||
| github-token: ${{ steps.trezor-bot-token.outputs.token }} | ||
| release-build: ${{ env.release_build }} | ||
| run-reporter: ${{ inputs.publishResultsToGitHub == 'true' || github.event_name == 'workflow_call' }} |
There was a problem hiding this comment.
the workflow's github.event_name was never 'workflow_call' because it inherits its parent status. Which was workflow_dispatch.
And at the first itteration the condition was github.event_name == 'workflow_dispatch'|| github.event_name == 'workflow_call'
That is why it worked until I have optimized it to inputs.publishResultsToGitHub == 'true' || github.event_name == 'workflow_call'
The condition was wrong from the start but my recent changes made it to profess this problem and report was not published when report orchestrator was run. This fix simplifies the logic and fixes the problem
Description
Related Issue
Resolve
Screenshots:
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents