refactor: global receive/send fixups #23380

cermakjiri · 2025-11-25T13:53:14Z

Description

refactor: global receive/send fixups

remove fiat rates from global receive
add search by account index
adjust list item spacing
update help url in global receive
remove hover state of icon in select (network filter) and fix text color based on design

Related Issue

Resolve #22678
Resolve #22677
Resolve #23261

Screenshots:

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

🔍🖥️ Suite native android test results: View in Currents

seibei-iguchi · 2025-11-25T13:58:21Z

packages/suite/src/components/suite/asset-picker/components/AssetRow/ItemClickableContainer.tsx

    box-shadow: unset;

-    width: 100%;
+    width: calc(100% - ${spacings.xxs * 2}px);


This is not necessary. Just add the items in a container with padding?

Also, I think the padding of the modal content should match the horizontal padding in the modal header.

It'll be this then:

Also, the scroll bar won't placed by the right edge.

Global send & receive modals + common components for general asset picker #22965 (comment)

Global send & receive modals + common components for general asset picker #22965 (comment)

Ok, I'll try something then:)

Here it is: #23388

Alright, I'll check it out then. Mainly, do not merge it else it will block the feature development. There would be conflicts in my upcoming branches. 🙏

Are you sure there'd be conflicts? My PR is built on top of this branch and handles more or less the same issues, i.e. looks

Are you gonna do anything else on top of this?

As I said before: yes and I've already done: #23314.

Btw there's known perf. issue with current implementation of the virtualized list (if there's a lot of items the rendering is super slow) as mentioned here. #23380 (comment). Any improvement would be very welcomed.

izmy · 2025-11-27T09:58:14Z

packages/suite/src/components/suite/asset-picker/components/AssetRow/ItemClickableContainer.tsx


    cursor: pointer;
-    padding: ${spacingsPx.sm} 0;
+    padding: ${spacingsPx.xs} 0;


padding-block: ${spacingsPx.xs};

This is gonna be changed anyway, see #23388

izmy · 2025-11-27T09:58:41Z

packages/suite/src/components/suite/asset-picker/components/AssetRow/ItemClickableContainer.tsx

    cursor: pointer;
-    padding: ${spacingsPx.sm} 0;
+    padding: ${spacingsPx.xs} 0;
+    margin: ${spacingsPx.xxs} ${spacingsPx.xxs};


margin: ${spacingsPx.xxs};

The same as above, #23388

trezor-bot · 2025-11-28T08:31:44Z

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

trezor-bot · 2025-11-28T08:31:45Z

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

- remove fiat rates from global receive - add search by account index - adjust list item spacing - update help url in global receive - remove hover state of icon in select (network filter) and fix text color based on design

cermakjiri · 2025-11-28T09:24:09Z

Fix undefined params in back route (i.e. no items were shown due to undefined networkSymbol):

Zaznam.obrazovky.2025-11-28.v.10.14.11.mov

Improve accounts search

Zaznam.obrazovky.2025-11-28.v.10.14.24.mov

Fix resolving coingeckoId in AssetRowToken
Make some perf. improvements of the virtualized list however there's still huge space for bigger refactor
- I'd suggest get rid of the custom implementation and use library for it (as there are many good of them), e.g. react-window.
- Or use better browser APIs and re-work the logic to be more efficient. I think the handleScroll could be replaced with more efficient intersection observe API
- The rest I didn't have time to think through of but I very confident this is not the best way of doing it.
- The amount of DOM changes is insane. We should only change item visibility and position, not the height. We should cache already rendered items, etc. Anyway, I think easiest would be using already proved solution by some library.

EuryShadow · 2025-12-03T15:38:06Z

On smaller screens, the add account button is partially or completely hidden.

Screen.Recording.2025-12-02.at.12.23.46.mov

cermakjiri requested a review from a team November 25, 2025 13:53

cermakjiri self-assigned this Nov 25, 2025

cermakjiri requested review from a team, jvaclavik, pavelmario and seibei-iguchi as code owners November 25, 2025 13:53

cermakjiri mentioned this pull request Nov 25, 2025

Global send & receive modals + common components for general asset picker #22965

Merged

3 tasks

seibei-iguchi reviewed Nov 25, 2025

View reviewed changes

cermakjiri requested review from a team and removed request for a team November 27, 2025 08:55

izmy approved these changes Nov 27, 2025

View reviewed changes

cermakjiri force-pushed the fix/22737-global-receive-send branch from 9f4d270 to 08cff93 Compare November 28, 2025 08:31

cermakjiri force-pushed the fix/22737-global-receive-send branch from 08cff93 to 846be8b Compare November 28, 2025 08:54

refactor: global receive/send fixups

950adce

- remove fiat rates from global receive - add search by account index - adjust list item spacing - update help url in global receive - remove hover state of icon in select (network filter) and fix text color based on design

cermakjiri force-pushed the fix/22737-global-receive-send branch from 846be8b to 950adce Compare November 28, 2025 09:12

cermakjiri enabled auto-merge (rebase) November 28, 2025 10:35

cermakjiri merged commit 3a107c8 into develop Nov 28, 2025
42 of 45 checks passed

cermakjiri deleted the fix/22737-global-receive-send branch November 28, 2025 10:39

zako05 mentioned this pull request Dec 2, 2025

Refactor/global send receive #23388

Closed

Uh oh!

refactor: global receive/send fixups #23380

refactor: global receive/send fixups #23380

Uh oh!

Conversation

cermakjiri commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Screenshots:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trezor-bot bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trezor-bot bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cermakjiri commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

EuryShadow commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cermakjiri commented Nov 25, 2025 •

edited

Loading

trezor-bot bot commented Nov 28, 2025 •

edited

Loading

trezor-bot bot commented Nov 28, 2025 •

edited

Loading

cermakjiri commented Nov 28, 2025 •

edited

Loading