Skip to content

Feat/native/delete unused translations script (DO NOT MERGE YET!) #23580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PeKne wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feat/native/delete unused translations script (DO NOT MERGE YET!) #23580

PeKne wants to merge 4 commits into from
+310 −56

Conversation

@PeKne
Copy link
Contributor

@PeKne PeKne commented Dec 2, 2025 •
edited
Loading

Description

  • adds a script that will remove all unused translation keys and sync it changes with Crowdin. The implementation is close as possible to desktop to avoid any platform specific confusion. Part of the script code is even shared with desktop script.
  • there is about 120 unsused translations but they are not removed in this PR yet. I want to test the removal from the CI workflow. Will be done after all the release 25.12 related Crowdin syncs will be done.

Notes for QA

Nothing to test, this code is running in CI workflow.

Related Issue

Resolve #21380

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

@PeKne PeKne requested review from a team, komret and vdovhanych as code owners December 2, 2025 18:10
@PeKne PeKne added the mobile Suite Lite issues and PRs label Dec 2, 2025
@PeKne PeKne added this to Suite Dec 2, 2025
@PeKne PeKne removed this from Suite Dec 2, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 2, 2025
View reviewed changes
@trezor-bot
Copy link
Contributor

trezor-bot bot commented Dec 3, 2025

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

jbazant
jbazant approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@jbazant jbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚢 🇮🇹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbazant jbazant jbazant approved these changes

@komret komret Awaiting requested review from komret komret is a code owner

@vdovhanych vdovhanych Awaiting requested review from vdovhanych vdovhanych is a code owner

Assignees

No one assigned

Labels

mobile Suite Lite issues and PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Localization - list unused script

3 participants

@PeKne @jbazant