Remove redux utils from suite sync #23678
Open
+871
−648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
commented
Dec 8, 2025
| * | ||
| * @deprecated This shall be removed, once we phase out the old Metadata code. | ||
| */ | ||
| export const processLegacyMetadataIntoSuiteSyncThunk = createThunk< |
Contributor
Author
There was a problem hiding this comment.
Just moved out of the SuiteSync
peter-sanderson
commented
Dec 8, 2025
| const secureStorage = isDesktop() | ||
| ? createElectronSecureStorage({ desktopApi }) | ||
| : createWebauthnSecureStorage(); | ||
| export const suiteExtraFactory: ExtraWithStoreFactory = store => { |
Contributor
Author
There was a problem hiding this comment.
Todo: This shall be moved/named suiteCompositionRoot.ts
peter-sanderson
commented
Dec 8, 2025
| "dependencies": { | ||
| "@reduxjs/toolkit": "2.10.1", | ||
| "@suite-common/metadata-types": "workspace:*", | ||
| "@suite-common/redux-utils": "workspace:*", |
peter-sanderson
force-pushed
the
remove-redux-utils-from-suite-sync
branch
from
ac6f0d7 to
d7002ef
Compare
…lar deps issue source
…ge circular deps issue source" This reverts commit a9cb0af.
peter-sanderson
force-pushed
the
remove-redux-utils-from-suite-sync
branch
from
d7002ef to
ca21a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deptype to remove a need for naming servicies🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents