fix(e2e-suite): Corrects wrong model looping, removes unnecessary wait #23686
+19
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HajekOndrej
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing
suite/e2e/tests/backup/t3t1-t2t1-create-additional-share.test.tsstability without wait for our firmware meeting. And it seems the problem is gone. So there won't be a meeting.As sideefect of testing, I undercover a bug we had in our tests. looping of models was wrong. It used same model in each iteration. I guess that is because test.use is not awaited but in some queue or something :/ So if we had
const models: Model[] = ['T1B1', 'T2T1', 'T3B1', 'T3T1'];thenT3T1would be run 4 times.Fix is that
for loopneeds to be above describe in which we set model using test.use.fixes typo in test file name
Description
Notes for QA
Related Issue
Resolve
Screenshots:
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents