Skip to content

refactor(networks): introduce branded network symbol - #30561

Open
peter-sanderson wants to merge 1 commit into
developfrom
simplify-network-symbol
Open

refactor(networks): introduce branded network symbol#30561
peter-sanderson wants to merge 1 commit into
developfrom
simplify-network-symbol

Conversation

@peter-sanderson

@peter-sanderson peter-sanderson commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

This PR introduces the layer-independent @trezor/network-module package with an open branded NetworkSymbol, replaces the generic Suite Common module registry with independent non-generic modules, and keeps each network family’s exhaustive literal union isolated behind explicit boundary conversion. Connect’s asCoinSymbol helper is now supplied by merged PR #30611 on develop.

  • Registry shape: 7 keyed fields → readonly SuiteCommonNetworkModule[]
  • Branch history: 10 commits → 1 commit
  • Focused type-check: 12 packages passed

🔍 Currents Test Results

🔍 Suite desktop test results: View in Currents

🔍 Suite web test results: View in Currents

🔍 Suite native android test results: View in Currents

🔒 Quarantined E2E Tests

Trezor Suite (web) — 3 test(s)
Test Type
Quarantine test: "Recovery - dry run,Recovery with device reconnection" 🙋 manual
Quarantine test: "TrezorConnect webextension -> Suite Web,second call after popup was closed by user should work" 🙋 manual
Quarantine test: "Recovery T2T1 - dry run,Recovery after partial recovery" 🙋 manual

Updated: 2026-08-05T16:00:48.746Z • 3 test(s) total

Trezor Suite (desktop) — 6 test(s)
Test Type
Send Base > User can perform ethereum sending on base network 🤖 auto
Send Base > User can set custom fees 🤖 auto
Passphrase reconnection > after device is reconnected passphrase needs to be confirmed 🤖 auto
Passphrase > basic flow 🤖 auto
Quarantine test: "Recovery - dry run,Recovery after partial recovery" 🙋 manual
Quarantine test: "Recovery - dry run,Recovery with device reconnection" 🙋 manual

Updated: 2026-08-05T15:59:58.703Z • 6 test(s) total

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/simplify-network-symbol/web/

@peter-sanderson peter-sanderson added the no-project This label is used to specify that PR doesn't need to be added to a project label Jul 30, 2026
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch 2 times, most recently from f1ebc8a to 37dbe68 Compare July 30, 2026 10:06
@peter-sanderson peter-sanderson mentioned this pull request Jul 30, 2026
3 tasks
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch from b58cb0a to 8b9d330 Compare July 30, 2026 14:22
@trezor-bot

trezor-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

✅ Previously successful run of [Test] suite-native Android E2E workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch 5 times, most recently from 6968bc2 to fb605fb Compare July 30, 2026 21:17
@peter-sanderson
peter-sanderson changed the base branch from develop to refactor/connect-as-coin-symbol July 30, 2026 21:20
@peter-sanderson
peter-sanderson force-pushed the refactor/connect-as-coin-symbol branch from 0935304 to c2bc1e2 Compare July 31, 2026 09:27
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch 2 times, most recently from e3fbec2 to 7b7bf3b Compare July 31, 2026 09:39
Base automatically changed from refactor/connect-as-coin-symbol to develop July 31, 2026 10:13
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch 12 times, most recently from 8a77d49 to 6b79830 Compare July 31, 2026 14:28
Comment thread packages/theme/src/coinsColors.ts Outdated
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch from b280c3b to 8459dbb Compare August 1, 2026 21:44
@peter-sanderson
peter-sanderson force-pushed the modularize-network-config branch from c32fcf6 to 2451e1e Compare August 1, 2026 21:54
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch from 8459dbb to 1f9b3ca Compare August 1, 2026 21:54
@peter-sanderson
peter-sanderson force-pushed the modularize-network-config branch from 2451e1e to d0b14d1 Compare August 1, 2026 22:22
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch from 1f9b3ca to f089222 Compare August 1, 2026 22:22
@peter-sanderson
peter-sanderson force-pushed the modularize-network-config branch from d0b14d1 to 4af06b1 Compare August 1, 2026 22:32
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch from f089222 to c884716 Compare August 1, 2026 22:33
@peter-sanderson
peter-sanderson force-pushed the modularize-network-config branch 5 times, most recently from 295174c to 387774a Compare August 3, 2026 10:41
@trezor-bot
trezor-bot Bot force-pushed the modularize-network-config branch from 387774a to acd5939 Compare August 4, 2026 09:05
Base automatically changed from modularize-network-config to develop August 4, 2026 10:57
@peter-sanderson
peter-sanderson force-pushed the simplify-network-symbol branch 13 times, most recently from 0ce5fc6 to 0ae924c Compare August 5, 2026 10:41
Comment thread suite-common/wallet-config/src/types.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-project This label is used to specify that PR doesn't need to be added to a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant