refactor(redux): narrow RTK thunk dependencies - #30767

Draft

peter-sanderson wants to merge 16 commits into

refactor/extra-selector-gettersfrom

refactor/selective-rtk-thunk-dependencies-all

peter-sanderson commented Aug 3, 2026 •

edited by trezor-bot Bot

Loading

Contributor

Description

Stacked on #30837. Narrows RTK createThunk state and extra contracts to the selectors, services, actions, and child thunk contracts each thunk actually uses. Dependency contracts are named per thunk and composed with intersections, allowing unit tests to construct focused dependency objects instead of the complete ExtraDependencies graph.\n\n- Updated: 59 files\n- Runtime changes: none intended\n- Validation: affected type-check, changed-file ESLint, formatting, project-reference checks, and dependency-injection unit tests pass.

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/refactor/selective-rtk-thunk-dependencies-all/web/

🔍 Currents Test Results

🔍 Suite desktop test results: View in Currents

🔍 Suite web test results: View in Currents

🔍 Suite native android test results: View in Currents

🔒 Quarantined E2E Tests

Trezor Suite (web) — 3 test(s)

Test	Type
Quarantine test: "Recovery - dry run,Recovery with device reconnection"	🙋 manual
Quarantine test: "TrezorConnect webextension -> Suite Web,second call after popup was closed by user should work"	🙋 manual
Quarantine test: "Recovery T2T1 - dry run,Recovery after partial recovery"	🙋 manual

Updated: 2026-08-05T11:55:08.221Z • 3 test(s) total

Trezor Suite (desktop) — 6 test(s)

Test	Type
Send Base > User can perform ethereum sending on base network	🤖 auto
Send Base > User can set custom fees	🤖 auto
Passphrase reconnection > after device is reconnected passphrase needs to be confirmed	🤖 auto
Passphrase > basic flow	🤖 auto
Quarantine test: "Recovery - dry run,Recovery after partial recovery"	🙋 manual
Quarantine test: "Recovery - dry run,Recovery with device reconnection"	🙋 manual

Updated: 2026-08-05T15:14:52.619Z • 6 test(s) total

peter-sanderson added the no-project label

peter-sanderson changed the base branch from develop to selective-rtk-thunk-dependencies

August 3, 2026 17:24

trezor-bot Bot commented Aug 3, 2026

Contributor

✅ Previously successful run of [Test] suite-native Android E2E workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

peter-sanderson mentioned this pull request

Epic: Remove global ExtraDependencies from all thunks #30770

Open

36 tasks

peter-sanderson commented

View reviewed changes

packages/suite/src/actions/bluetooth/bluetoothStopScanningThunk.ts Outdated

peter-sanderson commented

View reviewed changes

packages/suite/src/actions/bluetooth/initBluetoothThunk.ts Outdated

peter-sanderson commented

View reviewed changes

packages/suite/src/actions/bluetooth/initBluetoothThunk.ts Outdated

peter-sanderson commented

View reviewed changes

packages/suite/src/actions/bluetooth/initBluetoothThunk.ts Outdated

peter-sanderson commented

View reviewed changes

packages/suite/src/actions/labels/exportMetadataToBip329File.ts Outdated

peter-sanderson commented

View reviewed changes

packages/suite/src/actions/suite/suiteThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/connect-popup/src/connectPopupThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite/router/src/routerThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/token/stellarTokenThunks.ts Outdated

peter-sanderson force-pushed the refactor/selective-rtk-thunk-dependencies-all branch from 9e7b0a9 to 6849285 Compare

August 4, 2026 08:10

peter-sanderson commented

View reviewed changes

packages/suite/src/actions/wallet/markDeviceAsRecentlyConnectedThunk.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/uiEvent/defaultTrezorUIEventHandlerThunk.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/firmware/src/firmwareThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/redux-extra-dependencies/src/extraDependenciesType.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/redux-utils/src/createMiddleware.ts

peter-sanderson commented

View reviewed changes

suite-common/redux-utils/src/createReducerWithExtraDeps.ts

peter-sanderson commented

View reviewed changes

suite-common/redux-utils/src/createSingleInstanceThunk.ts

peter-sanderson commented

View reviewed changes

suite-common/redux-utils/src/createSliceWithExtraDeps.ts

peter-sanderson commented

View reviewed changes

suite-common/redux-utils/src/createThunk.ts

peter-sanderson commented

View reviewed changes

suite-common/redux-utils/src/index.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/blockchain/blockchainThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/firmware/src/getBinFilesBaseUrlThunk.ts Outdated

peter-sanderson force-pushed the refactor/selective-rtk-thunk-dependencies-all branch from 8cf2ace to 46dde9b Compare

August 4, 2026 13:34

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/explorer/explorerThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/send/sendFormThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/stablecoin-yield/stablecoinYieldDepositThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/stablecoin-yield/stablecoinYieldWrapThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/stablecoin-yield/stablecoinYieldWrapThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/stake/stakeThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/transactions/transactionsThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/transactions/transactionsThunks.ts Outdated

peter-sanderson commented

View reviewed changes

suite-common/wallet-core/src/transactions/transactionsThunks.ts Outdated

peter-sanderson force-pushed the refactor/selective-rtk-thunk-dependencies-all branch from aec626a to c2d0e86 Compare

August 4, 2026 16:28

Base automatically changed from selective-rtk-thunk-dependencies to develop

August 5, 2026 07:50

peter-sanderson force-pushed the refactor/selective-rtk-thunk-dependencies-all branch 2 times, most recently from 4a32e19 to 87787f1 Compare

August 5, 2026 11:48

peter-sanderson added 15 commits

August 5, 2026 15:44


          refactor(redux): narrow RTK thunk dependencies


          fix(redux): preserve void thunk dependencies

6799e65


          fix(suite): allow state-only thunk config


          fix(suite): omit empty Bluetooth thunk deps

1153bc9


          refactor(suite): omit empty RTK thunk dependencies

e9fff87


          refactor(suite): address selective thunk review

ce89c64


          refactor(suite): split Redux extra dependencies

0c11e6f


          refactor(suite): narrow recently connected device state

0c65ca1


          refactor(redux): compose reusable extra dependency types

c1e9f1e


          chore(suite): fix validation issues

a75dd3d


          fix(wallet): type yield allowance thunk state

343b7ac


          refactor(firmware): isolate update thunk dependencies

9df7668


          refactor(redux): address selective thunk review

712dc71


          chore(redux): fix package dependencies


          fix(redux): decouple typed thunk dispatch

a280520

peter-sanderson force-pushed the refactor/selective-rtk-thunk-dependencies-all branch from 87787f1 to a280520 Compare

August 5, 2026 13:46

peter-sanderson changed the base branch from develop to refactor/extra-selector-getters

August 5, 2026 13:48


          refactor(redux): infer thunk payload callback types

509825e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

At least 1 approving review is required to merge this pull request.

Labels