feat(suite): report settings/networks/explorer analytics event - #30855
Draft
vojtatranta wants to merge 1 commit into
Draft
feat(suite): report settings/networks/explorer analytics event#30855vojtatranta wants to merge 1 commit into
vojtatranta wants to merge 1 commit into
Conversation
Report the explorer event on Desktop only when the saved explorer configuration actually differs from the stored one, so a backend-only Confirm or a purely cosmetic edit emits nothing. Extract the explorer normalization out of the reducer into pure helpers shared via wallet-core, so the same comparison can be reused on Mobile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the explorer event on Desktop only when the saved explorer configuration actually differs from the stored one, so a backend-only Confirm or a purely cosmetic edit emits nothing.
Extract the explorer normalization out of the reducer into pure helpers shared via wallet-core, so the same comparison can be reused on Mobile.
Description
Notes for QA
Related Issue
Resolve
Screenshots:
🌐 Preview deployments
🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/30588-network-explorer-tracking-desktop/web/
🤖 LLM Test Recommendations
Summary: The change set centers on the coin backend/explorer settings form, reducer, and related analytics events. The highest-risk paths are the Settings > Coins custom backend UI and the analytics events emitted when backends change. Running the two high-priority tests provides direct coverage of these flows; the medium-priority tests extend confidence to alternative backend types (Electrum, Blockbook) and the broader coins settings page. No low-priority tests are recommended because the changed files are broad dependencies and the remaining tests do not plausibly exercise the backend/explorer path.
Changed files (7)
packages/suite/src/hooks/settings/useExplorerForm.test.tsxpackages/suite/src/hooks/settings/useExplorerForm.tssuite-common/wallet-core/src/explorer/explorerReducer.tssuite-common/wallet-core/src/explorer/explorerUtils.tssuite-common/wallet-core/src/index.tssuite-native/analytics/src/events/settingsChangeCoinBackendEvent.tssuite/analytics/src/events/settingsCoinsBackendEvent.tsRecommended tests (5)
🔴 High priority (2)
suite/e2e/tests/analytics/events.test.ts— This test explicitly changes custom coin backends in settings and asserts that the SuiteReady analytics event reflects the updated customBackends value. The changed analytics event files (settingsCoinsBackendEvent) and explorer reducer are directly on this code path.suite/e2e/tests/settings/coins-custom-backend.test.ts— Directly exercises the Settings > Coins custom backend flow: toggling networks, configuring correct and incorrect Blockbook backend URLs, checking the custom-backend indicator, and verifying discovery. This is the primary UI path affected by changes to useExplorerForm and the explorer reducer/utils.🟡 Medium priority (3)
suite/e2e/tests/settings/coins.test.ts— Covers the Coins settings page including enabling assets and configuring a custom Blockbook backend for ETH with the backend indicator. It shares the same settings UI and backend configuration state as the changed files.suite/e2e/tests/settings/electrum.test.ts— Configures a custom Electrum backend for regtest and verifies discovery and balances. This exercises an alternative backend type managed by the same explorer/backend state and settings form infrastructure.suite/e2e/tests/wallet/blockbook-discovery.test.ts— Sets custom Blockbook backends for BTC and LTC and asserts that discovery completes and the portfolio graph loads. It validates the backend configuration state end-to-end after settings changes.suite-native/analytics/src/events/settingsChangeCoinBackendEvent.tsUpdated: 2026-08-05T08:02:06.634Z
🔍 Currents Test Results
🔍 Suite desktop test results: View in Currents
🔍 Suite web test results: View in Currents
🔍 Suite native android test results: View in Currents
🔒 Quarantined E2E Tests
Trezor Suite (web) — 3 test(s)
Updated: 2026-08-05T08:03:29.768Z • 3 test(s) total
Trezor Suite (desktop) — 2 test(s)
Updated: 2026-08-05T08:02:35.670Z • 2 test(s) total