chore(deps): bump @walletconnect to 2.23.10 - #30868
Conversation
Diffed the published tarballs rather than trusting semver: the change is additive. @walletconnect/types is unchanged apart from sourcemaps, utils gains Canton helpers, sign-client gains a canton_prepareSignExecute engine key. No removed or renamed exports in any of the five packages. react-native-compat also bumps native dependencies (Android yttrium-wcpay 0.10.51 -> 0.10.58, iOS YttriumWrapper 0.10.50 -> 0.10.54), which no type-check, lint or unit test can cover — that part needs a native build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR bumps the WalletConnect v2.23.x dependency family from 2.23.9 → 2.23.10 across the Suite workspaces that use it, updating both workspace package.json files and the corresponding yarn.lock resolutions.
Changes:
- Bump
@walletconnect/{core,types,utils}in@suite-common/walletconnectto^2.23.10. - Bump
@walletconnect/{sign-client,types}insuite/e2eto^2.23.10. - Bump
@walletconnect/react-native-compatinsuite-native/appto^2.23.10, plus lockfile updates (including a newes-toolkitversion via transitive deps).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yarn.lock | Updates lockfile resolutions for WalletConnect packages to 2.23.10 and introduces updated transitive entries (e.g., es-toolkit). |
| suite/e2e/package.json | Bumps E2E workspace WalletConnect deps (sign-client, types) to ^2.23.10. |
| suite-native/app/package.json | Bumps mobile app’s @walletconnect/react-native-compat to ^2.23.10. |
| suite-common/walletconnect/package.json | Bumps shared WalletConnect deps (core, types, utils) to ^2.23.10. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@walletconnect/core": "^2.23.10", | ||
| "@walletconnect/types": "^2.23.10", | ||
| "@walletconnect/utils": "^2.23.10" |
Description
Bumps the whole
@walletconnect2.23.x family in lockstep,2.23.9→2.23.10:@walletconnect/{core,types,utils}suite-common/walletconnect@walletconnect/{sign-client,types}suite/e2e@walletconnect/react-native-compatsuite-native/appIndependent of #30865 — no shared commits, based directly on develop.
Why this is safe on the JS side
Verified by diffing the published tarballs rather than trusting semver. Every change is additive — no removed or renamed exports in any of the five packages:
@walletconnect/typesis byte-identical apart from sourcemaps. That is the package our code compiles against: 9 of our 11 imports areimport type { ProposalTypes / EngineTypes / SessionTypes / SignClientTypes / ISignClient }from it. The typed contract has not moved.@walletconnect/utilsgains one module (extractCantonTransfers,getCantonTransactionHashes).@walletconnect/sign-clientgains one engine key (canton_prepareSignExecute).@walletconnect/core's only.d.tschange is theRELAYER_SDK_VERSIONstring, and it re-pins its internales-toolkit1.44.0 → 1.45.1. That adds a secondes-toolkitentry to the lockfile; the 1.44.0 copy remains for storybook only, so production still bundles one.The remaining two imports are the
CoreandSignClientconstructors, whose signatures are unchanged.Notes for QA
react-native-compatbumps native dependencies — Androidcom.github.reown-com.yttrium:yttrium-wcpay0.10.51 → 0.10.58 and iOSYttriumWrapper0.10.50 → 0.10.54. No type-check, lint or unit test in the repo can validate that; it needs a prebuild and a real device/EAS build. A 7-version native bump inside a JS patch release is the one part of this PR that deserves manual attention.Please exercise WalletConnect pairing/session flows on mobile specifically (dApp connect, session approval, sign request, disconnect). Web/desktop is lower risk —
suite-common/walletconnectonly touchescore/types/utils, whose surface is unchanged.Verified locally:
type-checkpasses for@suite-common/walletconnect,@trezor/suite-e2e,@suite-native/appplus their dependency graphs (249 tasks).yarn install --immutablepasses against current develop.suite-common/walletconnecthas no unit tests, so type-check plus the WalletConnect e2e is the automated coverage available.Related Issue
Resolve
🌐 Preview deployments
🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/qa-bump-dep-connect/web/
🔍 Currents Test Results
🔍 Suite web test results: View in Currents
🔍 Suite desktop test results: View in Currents
🔒 Quarantined E2E Tests
Trezor Suite (desktop) — 3 test(s)
Updated: 2026-08-05T10:28:09.902Z • 3 test(s) total
Trezor Suite (web) — 3 test(s)
Updated: 2026-08-05T10:27:41.488Z • 3 test(s) total