Skip to content

test x86_64-pc-windows-gnullvm to see if it works#120

Closed
folkertdev wants to merge 1 commit into
mainfrom
try-ucrt
Closed

test x86_64-pc-windows-gnullvm to see if it works#120
folkertdev wants to merge 1 commit into
mainfrom
try-ucrt

Conversation

@folkertdev

Copy link
Copy Markdown
Member

cc #119

@codecov

codecov Bot commented Jul 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
fuzz-compress_then_decompress 50.89% <ø> (-0.03%) ⬇️
fuzz-decompress_chunked 31.43% <ø> (-1.46%) ⬇️
test-aarch64-apple-darwin 89.49% <ø> (ø)
test-x86_64-apple-darwin 89.49% <ø> (ø)
test-x86_64-unknown-linux-gnu 89.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@folkertdev
folkertdev force-pushed the try-ucrt branch 3 times, most recently from 26e99f2 to ac59fc5 Compare July 13, 2025 14:39
@folkertdev

Copy link
Copy Markdown
Member Author

@bjorn3 do you have recommendations for installing a linker that works here?

@bjorn3

bjorn3 commented Jul 13, 2025

Copy link
Copy Markdown
Collaborator

https://www.mingw-w64.org/downloads/#llvm-mingw points to https://github.com/mstorsjo/llvm-mingw/releases for getting an LLVM based MinGW toolchain. I think https://github.com/mstorsjo/llvm-mingw/releases/download/20250709/llvm-mingw-20250709-ucrt-x86_64.zip would work. You need to configure the bin/clang.exe binary inside this zip as linker.

@folkertdev
folkertdev force-pushed the try-ucrt branch 8 times, most recently from 1777425 to 35e025e Compare July 13, 2025 16:26
@folkertdev

Copy link
Copy Markdown
Member Author

hmm, so no it does not work?

 error: test failed, to rerun pass `--bin bzip2`
Caused by:
  process didn't exit successfully: `D:\a\libbzip2-rs\libbzip2-rs\target\x86_64-pc-windows-gnullvm\debug\deps\bzip2-bc14148a6a4d1307.exe` (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
     Running unittests bzip2recover.rs (target\x86_64-pc-windows-gnullvm\debug\deps\bzip2recover-45b3b08c58cee41b.exe)
error: test failed, to rerun pass `--bin bzip2recover`
Caused by:
  process didn't exit successfully: `D:\a\libbzip2-rs\libbzip2-rs\target\x86_64-pc-windows-gnullvm\debug\deps\bzip2recover-45b3b08c58cee41b.exe` (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
     Running tests\quick.rs (target\x86_64-pc-windows-gnullvm\debug\deps\quick-d427dba97e390a8a.exe)
error: test failed, to rerun pass `--test quick`
Caused by:
  process didn't exit successfully: `D:\a\libbzip2-rs\libbzip2-rs\target\x86_64-pc-windows-gnullvm\debug\deps\quick-d427dba97e390a8a.exe` (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
     Running tests\recover.rs (target\x86_64-pc-windows-gnullvm\debug\deps\recover-6a04c758313c0328.exe)
error: test failed, to rerun pass `--test recover`
Caused by:
  process didn't exit successfully: `D:\a\libbzip2-rs\libbzip2-rs\target\x86_64-pc-windows-gnullvm\debug\deps\recover-6a04c758313c0328.exe` (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
error: 4 targets failed:
    `--bin bzip2`
    `--bin bzip2recover`
    `--test quick`
    `--test recover`

@bjorn3

bjorn3 commented Jul 13, 2025

Copy link
Copy Markdown
Collaborator

You may need to add the right lib directory to the PATH env var. Note: Windows uses ; as separator, not :. On Windows PATH also acts as equivalent of LD_LIBRARY_PATH on Linux.

@folkertdev
folkertdev force-pushed the try-ucrt branch 3 times, most recently from 95f9f5c to ab898fa Compare July 13, 2025 17:11
Comment thread .github/workflows/checks.yaml Outdated
run: |
echo "llvm-mingw/llvm-mingw-20250709-ucrt-x86_64/bin" >> "$GITHUB_PATH"
echo "llvm-mingw/llvm-mingw-20250709-ucrt-x86_64/lib" >> "$GITHUB_PATH"
echo "llvm-mingw/llvm-mingw-20250709-ucrt-x86_64/armv7-w64-mingw32/bin" >> "$GITHUB_PATH"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the x86_64 path, not the armv7 library path, right

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh yes. but also I don't think writing to the github_path would actually have much effect here.

clearly, I have no idea what I'm doing here, and it's tough to debug in CI

@folkertdev
folkertdev force-pushed the try-ucrt branch 6 times, most recently from 43d6f99 to b601425 Compare July 13, 2025 17:54
@folkertdev

Copy link
Copy Markdown
Member Author

well, idk, feel free to give this a go but it's very user-hostile. Does anyone use this stuff?

@folkertdev folkertdev closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants