More various fixes#135
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
bjorn3
reviewed
May 11, 2026
| return core::ptr::null_mut(); | ||
| }; | ||
|
|
||
| let Ok(len) = usize::try_from(len) else { |
Collaborator
There was a problem hiding this comment.
Maybe convert to usize first to avoid unnecessary overflows? You did have to check for allocations >isize::MAX in that case though. LLVM considers those UB.
bjorn3
approved these changes
May 11, 2026
folkertdev
force-pushed
the
more-various-fixes
branch
2 times, most recently
from
May 11, 2026 15:39
72e76fa to
abdc49f
Compare
folkertdev
force-pushed
the
more-various-fixes
branch
from
May 11, 2026 15:52
abdc49f to
43d0a1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.