gate tests on features they use#475
Conversation
|
I missed that this was already forwarded, closing. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
zlib-rs/src/adler32/neon.rs
Outdated
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[cfg(all(test, feature = "std", target_feature = "neon"))] |
There was a problem hiding this comment.
Can you change this to
| #[cfg(all(test, feature = "std", target_feature = "neon"))] | |
| #[cfg(all(test, feature = "std", any(miri, target_feature = "neon")))] |
That way Miri can still find places where we assume a target feature but don't declare it.
There was a problem hiding this comment.
sorry for taking up your time, this is the same as #416 i think
There was a problem hiding this comment.
this one is for neon, that one for avx? This looks fine to me with the miri change, because neon is enabled by default on the linux and macos runners. The same is not true for x86, which makes it trickier.
There was a problem hiding this comment.
maybe it was me that misunderstood, I'll reopen with the suggested improvement.
2 participants
from: https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/zlib-rs/debian/patches/fix-aarch64-neon-tests.patch?ref_type=heads