Do not use communicators from other threads (#1909)

MinyazevR · web-flow · commit bb9e2771a0be · 2025-02-27T12:57:00.000+03:00
diff --git a/plugins/robots/utils/src/robotCommunication/robotCommunicator.cpp b/plugins/robots/utils/src/robotCommunication/robotCommunicator.cpp
@@ -37,12 +37,20 @@ RobotCommunicator::~RobotCommunicator()
 
 void RobotCommunicator::send(QObject *addressee, const QByteArray &buffer, const unsigned responseSize)
 {
-	mRobotCommunicationThreadObject->send(addressee, buffer, responseSize);
+	auto blockingConnectionType = mRobotCommunicationThreadObject->thread() == QThread::currentThread()
+			? Qt::DirectConnection : Qt::BlockingQueuedConnection;
+	QMetaObject::invokeMethod(mRobotCommunicationThreadObject.get(), [&](){
+		mRobotCommunicationThreadObject->send(addressee, buffer, responseSize);},
+	blockingConnectionType);
 }
 
 void RobotCommunicator::send(const QByteArray &buffer, const unsigned responseSize, QByteArray &outputBuffer)
 {
-	mRobotCommunicationThreadObject->send(buffer, responseSize, outputBuffer);
+	auto blockingConnectionType = mRobotCommunicationThreadObject->thread() == QThread::currentThread()
+			? Qt::DirectConnection : Qt::BlockingQueuedConnection;
+	QMetaObject::invokeMethod(mRobotCommunicationThreadObject.get(), [&](){
+		mRobotCommunicationThreadObject->send(buffer, responseSize, outputBuffer);},
+	blockingConnectionType);
 }
 
 void RobotCommunicator::connect()

Original file line number	Diff line number	Diff line change
`@@ -37,12 +37,20 @@ RobotCommunicator::~RobotCommunicator()`
`37`	`37`
`38`	`38`	`void RobotCommunicator::send(QObject *addressee, const QByteArray &buffer, const unsigned responseSize)`
`39`	`39`	`{`
`40`		`- mRobotCommunicationThreadObject->send(addressee, buffer, responseSize);`
	`40`	`+ auto blockingConnectionType = mRobotCommunicationThreadObject->thread() == QThread::currentThread()`
	`41`	`+ ? Qt::DirectConnection : Qt::BlockingQueuedConnection;`
	`42`	`+ QMetaObject::invokeMethod(mRobotCommunicationThreadObject.get(), [&](){`
	`43`	`+ mRobotCommunicationThreadObject->send(addressee, buffer, responseSize);},`
	`44`	`+ blockingConnectionType);`
`41`	`45`	`}`
`42`	`46`
`43`	`47`	`void RobotCommunicator::send(const QByteArray &buffer, const unsigned responseSize, QByteArray &outputBuffer)`
`44`	`48`	`{`
`45`		`- mRobotCommunicationThreadObject->send(buffer, responseSize, outputBuffer);`
	`49`	`+ auto blockingConnectionType = mRobotCommunicationThreadObject->thread() == QThread::currentThread()`
	`50`	`+ ? Qt::DirectConnection : Qt::BlockingQueuedConnection;`
	`51`	`+ QMetaObject::invokeMethod(mRobotCommunicationThreadObject.get(), [&](){`
	`52`	`+ mRobotCommunicationThreadObject->send(buffer, responseSize, outputBuffer);},`
	`53`	`+ blockingConnectionType);`
`46`	`54`	`}`
`47`	`55`
`48`	`56`	`void RobotCommunicator::connect()`