Skip to content

Retry input instead of error in case of empty input [AUTOZIP]#1111

Merged
iakov merged 1 commit intotrikset:masterfrom
IKhonakhbeeva:input
Sep 20, 2020
Merged

Retry input instead of error in case of empty input [AUTOZIP]#1111
iakov merged 1 commit intotrikset:masterfrom
IKhonakhbeeva:input

Conversation

@IKhonakhbeeva
Copy link
Contributor

При пустом вводе не выдавать ошибку, а заново открывать окно ввода

@IKhonakhbeeva IKhonakhbeeva requested a review from iakov September 18, 2020 11:23
@AppVeyorBot
Copy link

Download:
Environment: QT=5.12, ARCH=32, CONFIGURATION=release, QTIFW=C:\Qt\Tools\QtInstallerFramework\3.1
trik-studio-master-i686-auto.zip

@iakov iakov added this to the 2020.6 milestone Sep 18, 2020
bool checkLinksCount();
void onValueSelected(const QString &text);
void onRejected();
void retry();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно нужен отдельный метод?

if (mCancelBlockId.isNull()) {
error(tr("You must input some value!"));
warning(tr("You must input some value!"));
retry();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
retry();
Q_EMIT done(id());

@AppVeyorBot
Copy link

Download:
Environment: QT=5.12, ARCH=32, CONFIGURATION=release, QTIFW=C:\Qt\Tools\QtInstallerFramework\3.1
trik-studio-master-i686-auto.zip

@iakov
Copy link
Member

iakov commented Sep 20, 2020

Но это в мастер, а не в джуниор. А надо в джуниор ещё.

@iakov iakov merged commit bc0c3b5 into trikset:master Sep 20, 2020
@IKhonakhbeeva IKhonakhbeeva deleted the input branch October 19, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants