Conversation
…Sender -> connectionToVizualizer,
| $$PWD/src/engine/view/twoDModelWidget.ui \ | ||
|
|
||
| DISTFILES += \ | ||
| $$PWD/src/engine/trajectory/frames.proto |
| # limitations under the License. | ||
|
|
||
| QT += widgets xml svg | ||
| QT += network |
| { | ||
| if (connToVizualizator == nullptr) { | ||
| connToVizualizator = new ConnectionToVizualizator(); | ||
| connToVizualizator->setPort(8080); |
There was a problem hiding this comment.
Порт должен быть в опциях, хотя бы в Settings.
|
|
||
| /// saving it to file | ||
| QFile file("trajectory.json"); | ||
| if( file.open( QIODevice::WriteOnly | QIODevice::Text | QIODevice::Truncate ) ) { |
There was a problem hiding this comment.
Нет обработки ошибки, хотя бы QLOG_ERROR () <<
|
|
||
| try { | ||
| sendTrajectory(data); | ||
| } catch (exception e) {} |
There was a problem hiding this comment.
Исключения надо ловить по ссылке. Но это дурной тон ловить std::exception
| TrajectorySaver::TrajectorySaver(QObject *parent) | ||
| : QObject(parent) | ||
| { | ||
| connToVizualizator = new ConnectionToVizualizator(); |
| QTcpSocket *socket; | ||
| QTimer *keepaliveTimer; | ||
|
|
||
| QString Ip {"10.0.5.2"}; |
There was a problem hiding this comment.
Параметры сетевого соединения должны быть в настройках
|
|
||
| public: | ||
| // ConnectionToVizualizator(QString ip, int port); | ||
| ConnectionToVizualizator(); |
There was a problem hiding this comment.
Возможно, конструктору нужен параметр QObject *parent, раз уж это Q_OBJECT
| #include <QTimer> | ||
|
|
||
| /// Connection to Unity to send frames and run/stop/restart | ||
| class alignas(8) ConnectionToVizualizator : public QObject |
There was a problem hiding this comment.
А зачем тут alignas(8)? Такой код нельзя без комментария.
|
|
||
| private: | ||
| QTcpSocket *socket; | ||
| QTimer *keepaliveTimer; |
There was a problem hiding this comment.
В продукте принята схема именования полей с префиксом, то есть mSocket и подобное.
plugins/robots/common/twoDModel/src/engine/model/robotModel.cpp
Outdated
Show resolved
Hide resolved
plugins/robots/common/twoDModel/src/engine/model/robotModel.cpp
Outdated
Show resolved
Hide resolved
| #include "twoDModel/engine/twoDModelDisplayWidget.h" | ||
|
|
||
| #include "twoDModel/twoDModelDeclSpec.h" | ||
| #include "plugins/robots/common/twoDModel/src/engine/trajectory/connectionToVizualizator.h" |
| QDomDocument generateWorldModelWithBlobsXml() const; | ||
| QDomDocument generateWorldModelXml() const; | ||
| QDomDocument generateBlobsXml() const; | ||
| ConnectionToVizualizator *mConnToVizualizator; |
There was a problem hiding this comment.
Отсутствует инициализация {}, не указано, кто владеет объектом
| , mWorld(new b2World(b2Vec2(0, 0))) | ||
| , mPrevPosition(b2Vec2(0, 0)) | ||
| , mPrevAngle(0) | ||
| , mTrajSaver(new TrajectorySaver(nullptr)) |
There was a problem hiding this comment.
Думаю, что тут надо бы не nullptr
| item->setPos(scenePos - item->boundingRect().center()); | ||
| item->setRotation(angleToScene(mBox2DDynamicItems[item]->getRotation())); | ||
| } | ||
| auto *abstractItem = dynamic_cast<graphicsUtils::AbstractItem *>(item); |
| @@ -0,0 +1,166 @@ | |||
| /* Copyright 2022 Lada Egorova | |||
There was a problem hiding this comment.
По-моему, тут где-то обычно запятая есть. Но хоть так.
| <string>Network Settings</string> | ||
| </property> | ||
| <layout class="QGridLayout" name="gridLayout_5"> | ||
| <item row="0" column="2"> |
There was a problem hiding this comment.
Не надо перетаскивать элементы в XML, это лишь увеличивает diff
ladaegorova18
changed the title
iakov
force-pushed
the
master
branch
8 times, most recently
from
cd7a4ab to
ff6360f
Compare
iakov
force-pushed
the
master
branch
3 times, most recently
from
dde4319 to
06af258
Compare
3 participants
No description provided.