Closed
Conversation
zhitm
force-pushed
the
master
branch
4 times, most recently
from
c4b5f98 to
f828e2b
Compare
This was referenced Dec 21, 2023
iakov
requested changes
Jan 10, 2024
Member
iakov
left a comment
iakov
left a comment
There was a problem hiding this comment.
Very impressive! But small polishing is required.
plugins/robots/generators/nxt/nxtOsekCGenerator/nxtOsekCGeneratorPlugin.cpp
Show resolved
Hide resolved
| setColorOnGeneratorLabel(QColor("red")); | ||
| } | ||
| else { | ||
| mUi->generatorLabel->setText("Current directory exist."); |
Member
There was a problem hiding this comment.
If the text is not intended to be shown to the user, please, state this clearly in the code. I recommend to use string literals like following
auto x = "*SOME TEMPORARY TEXT NOT FOR USER*"
plugins/robots/interpreters/nxtKitInterpreter/src/nxtAdditionalPreferences.cpp
Show resolved
Hide resolved
plugins/robots/generators/nxt/nxtOsekCGenerator/nxtOsekCGeneratorPlugin.cpp
Show resolved
Hide resolved
| case QOperatingSystemVersion::OSType::Windows: { | ||
| auto pathToNxtTools = path().replace("\\", "/"); | ||
| auto line = path("compile.bat") | ||
| + " " + fileInfo.completeBaseName() |
Member
There was a problem hiding this comment.
Probably, file names with spaces are handled incorrectly here after the single line is combined.
Member
|
Merged with #1900, thank you very much for your great effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I've added NXT support for GNU/Linux so this PR allows to compile and load programs via USB connection on Lego NXT.
Why?
There's no NXT support for GNU/Linux, but it exist for Windows.
How?
I've changed structure of nxt-tools. There is no more
winandlinuxdirectories. I use gcc-arm-none-eabi to compile C code on GNU/Linux same way as on Windows. In order not to increase the volume of the installer, the user is given the opportunity to run the download-arm-none-eabi.sh script.There are some changes in compile.sh and compile.bat to pass sysroot as argument and use sysroot as compile option. There are also added more setting to choose cross compiler path as shown on image below. I've added widget dirPicker to choose path.
Screenshots
Other info
The imagePicker widget exist, but it only allows you to select image path. To reduce code repetitions it would be a good idea to unify that widget and dirPicker.
Linked pull requests
PR to nxt-tools
PR to trik-help