Add basic support for system theme (fix dark theme)#1896
Merged
iakov merged 3 commits intotrikset:masterfrom Feb 26, 2025
Merged
Add basic support for system theme (fix dark theme)#1896iakov merged 3 commits intotrikset:masterfrom
iakov merged 3 commits intotrikset:masterfrom
Conversation
AlexandrKudrya
changed the title
iakov
changed the title
MinyazevR
reviewed
Jan 28, 2025
plugins/robots/common/twoDModel/src/engine/items/commentItem.cpp
Outdated
Show resolved
Hide resolved
plugins/robots/common/twoDModel/src/engine/view/parts/robotItemPopup.h
Outdated
Show resolved
Hide resolved
plugins/robots/interpreters/interpreterCore/src/managers/actionsManager.cpp
Outdated
Show resolved
Hide resolved
plugins/robots/interpreters/interpreterCore/include/interpreterCore/managers/actionsManager.h
Outdated
Show resolved
Hide resolved
AlexandrKudrya
force-pushed
the
master
branch
from
d051287 to
cbf0465
Compare
iakov
reviewed
Jan 31, 2025
AlexandrKudrya
force-pushed
the
master
branch
from
cbf0465 to
4e576cb
Compare
MinyazevR
reviewed
Feb 1, 2025
plugins/robots/interpreters/interpreterCore/include/interpreterCore/managers/actionsManager.h
Outdated
Show resolved
Hide resolved
AlexandrKudrya
force-pushed
the
master
branch
from
684a0fa to
01e0691
Compare
iakov
approved these changes
Feb 26, 2025
Member
iakov
left a comment
iakov
left a comment
There was a problem hiding this comment.
OK, thank you. Nice work, this feature is a long-awaited one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially helps with #1712 , at least for High Contrast on Windows, Dark mode for KDE-based GNU/Linux distros, and macOS dark theme.
AbstractItem::loadThemedIcon()andAbstractItem::loadTextColorIcon();.inifiles;