Skip to content

Proccess UI events before the next block starts executing #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MinyazevR wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Proccess UI events before the next block starts executing #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qrutils/interpreter/block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* limitations under the License. */

#include <qrutils/interpreter/block.h>

#include <QCoreApplication>
#include <QsLog.h>
#include <qrtext/languageToolboxInterface.h>
#include <qrgui/plugins/pluginManager/editorManagerInterface.h>
Expand Down Expand Up @@ -99,7 +99,7 @@
return true;
}

const Id Block::id() const

Check warning on line 102 in qrutils/interpreter/block.cpp

View workflow job for this annotation

GitHub Actions / build-ubuntu-release-tests / build

qrutils/interpreter/block.cpp:102:1 [readability-const-return-type] 

return type 'const qReal::Id' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
{
return mGraphicalId;
}
Expand All @@ -110,7 +110,7 @@
if (mState == failed) {
return;
}

QCoreApplication::processEvents();
mState = running;
mThread = thread;
if (initNextBlocks()) {
Expand Down Expand Up @@ -156,7 +156,7 @@
// graphical id existed when this Block instance was constructed (or we just will not get here),
// but now the logical instance has suddenly disppeared.
error(tr("Block has disappeared!"));
return QVariant();

Check warning on line 159 in qrutils/interpreter/block.cpp

View workflow job for this annotation

GitHub Actions / build-ubuntu-release-tests / build

qrutils/interpreter/block.cpp:159:10 [modernize-return-braced-init-list] 

avoid repeating the return type from the declaration; use a braced initializer list instead
}

return mLogicalModelApi->propertyByRoleName(logicalId, propertyName);
Expand Down
Loading