Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Belos: Add Generalized Conjugate Residual (GCR) linear solver #12247

Draft
wants to merge 52 commits into
base: develop
Choose a base branch
from
Draft

Belos: Add Generalized Conjugate Residual (GCR) linear solver #12247

wants to merge 52 commits into from
+1,983 −0

Conversation

vqd8a
Copy link
Contributor

@vqd8a vqd8a commented Sep 12, 2023 •
edited
Loading

@trilinos/belos, @hkthorn, @jennloe

Motivation

This PR is to add an initial implementation of the Generalized Conjugate Residual (GCR) solver. This solver is needed by Gemma used with its Schur-complement PCA preconditioner. The GCR algorithm is based on the algorithm described in the "Iterative Methods for Sparse Linear Systems" book (by Yousef Saad). Currently, this implementation only supports single RHS and left preconditioner. Mutilple RHS and right preconditioner will be implemented in future PRs.

Stakeholder Feedback

Testing

This solver has been tested by the Gemma team.

vqd8a and others added 30 commits July 1, 2023 16:46
@vqd8a
Initially adding GCR solver
ae5dbc5
@vqd8a
Remove temp file
7be1df2
@vqd8a
Rename GCR
3d86ebb
@vqd8a
Merge branch 'develop' into belos-add-gcr-solver
260f32f
@vqd8a
Merge branch 'develop' into belos-add-gcr-solver
931ba1e
@vqd8a
Merge branch 'develop' into belos-add-gcr-solver
9e49b5b
@vqd8a
Implement GCR
08d8b7a
@vqd8a
Fix correctness issue
03b847e
@vqd8a
Residual scaling by Norm of Preconditioned Initial Residua
d336351
@vqd8a
Remove some unnecessary operations
ba3be30
@cabejackson
Add SimpleTesting directory
fc79eff
@vqd8a
Match variable names with the GCR algorithm in Yousef Saad's book
0f17f0d
@vqd8a
Add note of Yousef Saad's book
50fea3c
@cabejackson
WIP:update pr-ctest-framework to SimpleTesting
cbd3ad4
@cabejackson
Update to cmake/SimpleTesting
330cd6a
@cabejackson
Update comments
48ccff2
@cabejackson
Update path name
9986f26
@JacobDomagala
Zoltan2: Refactor of BasisVectorAdapter to use Kokkos data structures
77dcd2c 
Zoltan2: Provide helper test macros and functions

27: Refactoring of BasisVectorAdapter

27: Fixed coordinatesview test for BasicVectorAdapter

27: Implemented getIds and getWeights methods with tests

27: Improved test and cleaned BasicVectorAdapter

Removed a double space
@JacobDomagala
Zoltan2: Fix warnings and formatting
89c2956
@cabejackson
Update documentation/remove unecessary comments
72d082c
@cabejackson
Fix typo
ad15a5c
@csiefer2
Tpetra: Removing the incorrect ETI_DEVICES
f031da8 
We don't use them and they're not consistent with the ETI_NODES
@thearusable
Belos: Remove use of hardcoded MPI_COMM_WORLD
bd5eab8
@vqd8a
Add no preconditioner case
627ba12
@vqd8a
Add tpetra unit test for GCR
beedc63
@vqd8a
Remove dedundant file
a0d83df
@cabejackson
Merge pull request trilinos#12169 from trilinos/TRILFRAME-592-Add-Sim…
989a316 
…pleTesting

Framework: Add SimpleTesting to Trilinos
@trilinos-autotester
Merge Pull Request trilinos#12207 from brian-kelley/Trilinos/FixKK1959
5382f31 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: b'Stokhos: fix KokkosKernels trilinos#1959'
PR Author: brian-kelley
@vqd8a
Another unit test for GCR
6a69b0b
@cwschilly
Zoltan2: fix shadow warning
83c26bb
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

28 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@jhux2 jhux2 added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkthorn hkthorn Awaiting requested review from hkthorn

@jennloe jennloe Awaiting requested review from jennloe

At least 1 approving review is required to merge this pull request.

Assignees

@vqd8a vqd8a

Labels
AT: STALE Added by the PR autotester if too much time has elapsed since the last successful PR test iteration AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) client: Gemma ATDM code Gemma PA: Linear Solvers Issues that fall under the Trilinos Linear Solvers Product Area pkg: Belos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.