Skip to content

Tpetra: add is_unified_memory_space to Node #14682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Tpetra: add is_unified_memory_space to Node #14682

wants to merge 1 commit into from
+4 −0

Conversation

@brian-kelley
Copy link
Contributor

@brian-kelley brian-kelley commented Nov 11, 2025

True for architectures like AMD_GFX942_APU where the device space is not HostSpace, but it's still accessible on host.
Might help for cases where special logic is required for APUs, like #14681.

@trilinos/tpetra

@brian-kelley brian-kelley requested a review from a team as a code owner November 11, 2025 19:59
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

CDash for AT1 results [Only accessible from Sandia networks]
CDash for AT2 results [Currently only accessible from Sandia networks]

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 11, 2025

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 11, 2025

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2653
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 14682
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 89531b9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4a5f2cb

Using Repos:

Repo: TRILINOS (brian-kelley/Trilinos)
  • Branch: APU
  • SHA: 89531b9
  • Mode: TEST_REPO

Pull Request Author: brian-kelley

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 11, 2025

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2653
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 14682
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 89531b9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4a5f2cb


CDash Test Results for PR# 14682.

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 11, 2025

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 11, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 12, 2025

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 12, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@brian-kelley
Tpetra: add is_unified_memory_space to Node
29ebe79 
True for architectures like AMD_GFX942_APU where the device
space is not HostSpace, but it's still accessible on host.

Signed-off-by: Brian Kelley <[email protected]>
@brian-kelley brian-kelley requested a review from cgcgcg November 13, 2025 06:59
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Your PR updated files that did not respect package formatting settings.
Please apply the patch given below. Alternatively you can download a patch file here.

Patch 
diff --git a/packages/tpetra/core/compat/Tpetra_KokkosCompat_ClassicNodeAPI_Wrapper.hpp b/packages/tpetra/core/compat/Tpetra_KokkosCompat_ClassicNodeAPI_Wrapper.hpp
index 562a7027..6d92656d 100644
--- a/packages/tpetra/core/compat/Tpetra_KokkosCompat_ClassicNodeAPI_Wrapper.hpp
+++ b/packages/tpetra/core/compat/Tpetra_KokkosCompat_ClassicNodeAPI_Wrapper.hpp
@@ -67,7 +67,7 @@ class KokkosDeviceWrapperNode {
 
   //! Whether the device is an APU with a single memory space shared between device and host (but which is not HostSpace).
   static constexpr bool is_unified_memory_space = is_gpu &&
-    Kokkos::SpaceAccessibility<Kokkos::DefaultHostExecutionSpace, typename execution_space::memory_space>::accessible;
+                                                  Kokkos::SpaceAccessibility<Kokkos::DefaultHostExecutionSpace, typename execution_space::memory_space>::accessible;
 
   KokkosDeviceWrapperNode(Teuchos::ParameterList& /* params */) = delete;
   KokkosDeviceWrapperNode()                                     = delete;

More details about our use of clang-format and other tools can be found in the wiki.

@brian-kelley brian-kelley changed the title Tpetra: add is_apu to Node Tpetra: add is_unified_memory_space to Node Nov 13, 2025
@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 13, 2025

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 13, 2025

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2661
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Tpetra
PULLREQUESTNUM 14682
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 29ebe79
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 35246d6

Using Repos:

Repo: TRILINOS (brian-kelley/Trilinos)
  • Branch: APU
  • SHA: 29ebe79
  • Mode: TEST_REPO

Pull Request Author: brian-kelley

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 13, 2025

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2661
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Tpetra
PULLREQUESTNUM 14682
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 29ebe79
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 35246d6


CDash Test Results for PR# 14682.

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 13, 2025

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 13, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgcgcg cgcgcg Awaiting requested review from cgcgcg

At least 1 approving review is required to merge this pull request.

Assignees

@brian-kelley brian-kelley

Labels

pkg: Tpetra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brian-kelley @trilinos-autotester @cgcgcg