TMToast - Getting exception when click close button #450 - #451
Merged
amosekr merged 2 commits intoOct 22, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a double-removal exception in the TMToast control where clicking the close button would remove the popup, and then the auto-dismiss timer would attempt to remove it again after the delay expired.
Key Changes:
- Added a boolean flag to track popup closure state
- Conditional check prevents duplicate removal attempts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Trimble.Modus.Components.csproj | Version bump to 1.3.0.3 for the bug fix release |
| TMToastContents.xaml.cs | Added isPopupClosed flag and guard condition to prevent double-removal of popup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sofiya-kumar
approved these changes
Oct 22, 2025
rthanga1
approved these changes
Oct 22, 2025
amosekr
deleted the
450-tmtoast---getting-exception-when-click-close-button
branch
October 22, 2025 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the TMToast control, we encountered an exception because the popup was being removed twice. Initially, the popup was removed when the close button was clicked, and then it was removed again after the delay time expired. This was the cause of the issue. It has now been fixed as part of ticket #450.