Skip to content

Memory leakage on modus controls #452 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rthanga1 merged 1 commit into from
Nov 27, 2025
Merged

Memory leakage on modus controls #452 #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Trimble.Modus.Components/Controls/DropDown/TMDropDown.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using Trimble.Modus.Components.Popup.Services;

namespace Trimble.Modus.Components;
public partial class TMDropDown : ContentView, IDisposable
public partial class TMDropDown : ContentView
{
#region Private fields
private double desiredHeight;
Expand Down Expand Up @@ -136,6 +136,7 @@ public TMDropDown()
InitializeComponent();
this.SetDynamicResource(StyleProperty, "DefaultStyle");
PopupService.Instance.Dismissed += OnPopupRemoved;
this.Unloaded += OnUnloaded;
}
#endregion

Expand Down Expand Up @@ -383,8 +384,16 @@ protected override void OnHandlerChanged()
public void Dispose()
{
PopupService.Instance.Dismissed -= OnPopupRemoved;
this.Unloaded -= OnUnloaded;
SelectionChanged = null;
SelectionChangedCommand = null;
ItemsSource = null;
dropDownContents = null;
previousSelection = null;
}

private void OnUnloaded(object sender, EventArgs e)
{
Dispose();
}
}
2 changes: 1 addition & 1 deletion Trimble.Modus.Components/Trimble.Modus.Components.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<PackageId>Trimble.Modus.Components</PackageId>
<Title>Trimble Modus</Title>
<Version>1.4.0</Version>
<Version>1.4.0.1</Version>
<Authors>Trimble Inc</Authors>
<Company>Trimble Inc</Company>
<Product>Trimble.Modus.Components</Product>
Expand Down
Loading