Skip to content

Dropdown popup is not opening in .net 10 #457 #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amosekr merged 2 commits into from
Dec 2, 2025
Merged

Dropdown popup is not opening in .net 10 #457 #458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
988719b
Dropdown popup is not opening in .net 10 #457
amosekr Dec 2, 2025
8599a70
Fixed review comment
amosekr Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Trimble.Modus.Components/Controls/DropDown/DropDownContents.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,18 @@ internal DropDownContents(View anchorView, Enums.ModalPosition position) : base(
public Thickness Margin { get; set; }
public IEnumerable ItemSource { get; set; }
public double DesiredHeight { get; set; }
public double DesiredWidth { get; set; }
Comment thread
rthanga1 marked this conversation as resolved.
public EventHandler<SelectedItemChangedEventArgs> SelectedEventHandler { get; set; }
public int SelectedIndex { get; set; }
public double YPosition { get; set; }
public new double Height { get; set; }

public Action ChangeIndicatorWhenPopupRemove { get; set; }
Comment thread
rthanga1 marked this conversation as resolved.
public void Build()
{
Animation = new RevealAnimation(DesiredHeight);
border.Margin = Margin;
border.HeightRequest = DesiredHeight;
border.WidthRequest = WidthRequest;
border.WidthRequest = DesiredWidth;
listView.ItemsSource = ItemSource;
if (SelectedIndex < 0)
{
Expand All @@ -70,7 +71,11 @@ public void Build()
#endif
}
}

protected override void OnDisappearing()
{
base.OnDisappearing();
ChangeIndicatorWhenPopupRemove?.Invoke();
}
private static void UpdateBackgroundColorOfCell(ListView listView)
{
if (listView.SelectedItem != null)
Expand Down
7 changes: 4 additions & 3 deletions Trimble.Modus.Components/Controls/DropDown/TMDropDown.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,11 @@ private async void Open()
SelectedItem = this.SelectedItem,
Margin = margin,
DesiredHeight = desiredHeight,
WidthRequest = innerBorder.Width,
DesiredWidth = innerBorder.Width,
SelectedEventHandler = OnSelected,
YPosition = loc.Y,
Height = height
Height = height,
ChangeIndicatorWhenPopupRemove = OnPopupRemoved
};
dropDownContents.Build();
await Task.WhenAll(
Expand All @@ -260,7 +261,7 @@ await Task.WhenAll(
}
}

private void OnPopupRemoved(object sender, EventArgs e)
private void OnPopupRemoved()
{
Close();
}
Expand Down
2 changes: 1 addition & 1 deletion Trimble.Modus.Components/Controls/Popup/Animations/RevealAnimation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public override void Preparing(View content, PopupPage page)
if (HasBackgroundAnimation)
{
_defaultOpacity = page.Opacity;
page.HeightRequest = 0;
//page.HeightRequest = 0;
}
else if (content != null)
{
Expand Down
2 changes: 1 addition & 1 deletion Trimble.Modus.Components/Trimble.Modus.Components.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<PackageId>Trimble.Modus.Components</PackageId>
<Title>Trimble Modus</Title>
<Version>1.4.0.2</Version>
<Version>1.4.0.3</Version>
<Authors>Trimble Inc</Authors>
<Company>Trimble Inc</Company>
<Product>Trimble.Modus.Components</Product>
Expand Down
Loading