This repository was archived by the owner on Jul 24, 2026. It is now read-only.
feat: add a startup environment check - #20
Merged
Conversation
We have no control over the installed DMS and Quickshell versions. When an incompatible version breaks an import, the widget silently disappears and the only trace is a log line. DMS gates plugin loading on an optional startupCheck component, so use it: compiling the entry points catches missing modules and types across all our imports, and DMS turns the failure into a toast that tells the user what is wrong instead of inviting a bug report. Property level and behavioral drift still slip through, this only upgrades the loudest failure class. Closes #6
The manifest switched to the components map when the daemon split landed, and DMS only understands that map since 1.5.0. Older versions reject the manifest before any plugin code runs, so the 1.4 floor has been wrong since then. The new startup check needs 1.5.0 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a DMS startupCheck that compiles the entry points and blocks loading with an explanatory toast when the environment is incompatible. Closes #6