Add session properties configuration

[sudohainguyen]

The MR is about to support passing file-based session property config and mount to config path which is default by /etc/trino

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[sudohainguyen]

hi @nineinchnick is there any. blockers?

[nineinchnick]

No, except for the signed CLA. They're processed every 2-3 weeks, and I'd expect the next batch to be processed in a few days.

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[nineinchnick]

@sudohainguyen you know you can run tests locally, right? :-)

[sudohainguyen]

@nineinchnick my bad, been trying to run test script in local but got this

./test.sh: line 5: default: unbound variable

[nineinchnick]

Which version of bash do you use? If you have 3.x, try upgrading to 5.x. Bash 3 is 21 years old.

[sudohainguyen]

ah right, that's it! let me try

[sudohainguyen]

cannot upgrade directly in my mac, any other ways?
good now, running test

[sudohainguyen]

passed in local with the change but got pod trino-g3ayjhc6cq-trino-test-networkpolicy failed

[nineinchnick]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[Copilot]

Pull Request Overview

This PR adds support for mounting Trino session property configurations via a file or properties, aligned with the official session property manager.

• Introduce a sessionProperty key in Helm chart values with two modes (configmap or properties).
• Update the coordinator ConfigMap template to generate session-property-config.properties and JSON based on the chosen mode.
• Add examples in values.yaml, tests, and a README entry for the new sessionProperty configuration.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
tests/trino/test-values.yaml	Added sessionProperty and sample session properties JSON; inserted system_session_properties.
charts/trino/values.yaml	Defined sessionProperty in default values with commented examples for both modes.
charts/trino/templates/configmap-coordinator.yaml	Render session-property configuration files when sessionProperty is set.
charts/trino/README.md	Documented the new sessionProperty top-level value.

Comments suppressed due to low confidence (4)

charts/trino/templates/configmap-coordinator.yaml:120

• The condition if .Values.sessionProperty is always true (defaults to {}), causing Helm to fail when no type is set. Change the guard to check for the presence of .Values.sessionProperty.type instead.

{{- if .Values.sessionProperty }}

tests/trino/test-values.yaml:349

• This duplicate sessionProperties block does not match the chart's expected sessionProperty schema. Rename or remove it to keep test values aligned with the Helm chart values.

sessionProperties: |-

charts/trino/README.md:352

• [nitpick] Expand this entry to document the sessionProperty sub-fields (type, sessionPropertiesConfig, properties) and include usage examples for both modes.

* `sessionProperty` - object, default: `{}`

tests/trino/test-values.yaml:325

• Add a test scenario for the properties mode (setting type: properties and properties block) to validate that both template branches for sessionProperty are covered.

sessionProperty:

[sudohainguyen]

mind reviewing again @nineinchnick ?

[nineinchnick]

I think plural sessionProperties is a bit better. It configures the session property manager, and session property implies something related to a single property.