Fix group auth secret not injected correctly #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
also need you to take a look here @nineinchnick |
nineinchnick
force-pushed
the
fix-group-db-secret-not-injected-correctly
branch
from
b8c68df to
22ec56b
Compare
nineinchnick
force-pushed
the
fix-group-db-secret-not-injected-correctly
branch
from
22ec56b to
1436009
Compare
Member
|
Thanks. I rebased this on master since there was a similar fix recently in #361. I'd stick to plural groups in the property name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the chart support passing external secret as group db via
groupAuthSecretbesides adding directly togroupsunderauthsection , there is some typos and logic missing causinggroup-provider.propertiesnot being created, leads to the renderedgroup.dbnot being injected into the cluster