Feature/add support for kubernetes gateway api #388
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -0,0 +1,57 @@ | |||
| # Example values for production Gateway API configuration with TLS | |||
There was a problem hiding this comment.
This file is not used and can get out-of-date. I'd remove it. If there are important settings that cannot be used in test-gateway-values.yaml, but are still worth documenting, consider putting them in comments there.
| @@ -0,0 +1,32 @@ | |||
| # Test values for Gateway API with advanced routing rules | |||
There was a problem hiding this comment.
Same here, avoid keeping unused files here.
| [exchange_manager_values]="--values test-exchange-manager-values.yaml" | ||
| [graceful_shutdown]="--values test-graceful-shutdown-values.yaml" | ||
| [resource_groups_properties]="--values test-resource-groups-properties-values.yaml" | ||
| [gateway]="--values test-gateway-values.yaml" |
There was a problem hiding this comment.
This test should be called from .github/workflows/ci-cd.yaml.
Should we install some gateway implementation in the kind cluster?
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
2 participants
Add support for kubernetes gateway api.
Fixes #387