Add query-manager.required-workers guidance to KEDA documentation#409
Open
jmealo wants to merge 1 commit intotrinodb:mainfrom
Open
Add query-manager.required-workers guidance to KEDA documentation#409jmealo wants to merge 1 commit intotrinodb:mainfrom
jmealo wants to merge 1 commit intotrinodb:mainfrom
Conversation
Document how to configure query-manager.required-workers and query-manager.required-workers-max-wait in additionalConfigProperties when using KEDA with scale-to-zero. Without these settings, queries submitted while workers are scaled to zero fail immediately instead of waiting for workers to start.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Author
|
CLA sent just prior to pening this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.kedasection invalues.yamlexplaininghow to configure
query-manager.required-workersandquery-manager.required-workers-max-waitviaadditionalConfigPropertieswhen using KEDA with scale-to-zero
README.mdviahelm-docsWithout these Trino-side settings, queries submitted while workers are
scaled to zero fail immediately with an "Insufficient active worker nodes"
error instead of entering a
WAITING_FOR_RESOURCESstate and waiting forworkers to start.
The referenced Trino properties are being documented in trinodb/trino#28902.
Test plan
helm-docsgenerates the README correctlyadditionalConfigPropertiesexample is valid