Add OPA sidecar for the coordinator#428
Open
tadeha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opa.*values block.access-control.propertieswhenopa.enabled=trueandaccessControlis unset. User-suppliedaccessControlis respected unchanged, so existing installs are unaffected.test-opa.yaml) covering both denied and allowed users, and anopaCI scenario intests/trino/test.sh.Motivation
OPA is the policy engine behind Trino's OPA access-control plugin.
Until now, operators had to wire it manually via
sidecarContainers.coordinatorplusaccessControl.properties, duplicating logic across deployments. This PR adds OPA as a built-in chart option: users supply a policy, the chart handles sidecar wiring, access-control properties, probes, and security context.Testing
helm lint charts/trinoandhelm lint -f tests/trino/test-opa-values.yaml.helm templateverified for: default (no OPA), opa-enabled inline policy, opa-enabled with externalpolicyConfigMap, opa-enabled with manualaccessControl(auto-wire skipped), and the two failure paths (empty policy → fail, bothpolicyandpolicyConfigMapset → fail)../tests/trino/test.sh -t opaend-to-end on kind: bothtest-connection(admin) andtest-opa(denied + allowed) pass.Docs
helm-docsregenerated.