Add worker PodDisruptionBudget to trino helm chart#429
Open
andrii29 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds configurable PodDisruptionBudget support for Trino worker pods in the Helm chart, with corresponding values and documentation updates.
Changes:
- Introduces
worker.podDisruptionBudgetin chart values (and test values). - Adds a new Helm template to render a Worker
PodDisruptionBudgetwhen configured. - Documents the new configuration in the chart README.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/trino/test-values.yaml | Adds worker.podDisruptionBudget to test values. |
| charts/trino/values.yaml | Documents and exposes worker.podDisruptionBudget configuration. |
| charts/trino/templates/poddisruptionbudget-worker.yaml | New template that conditionally renders a Worker PDB. |
| charts/trino/README.md | Documents worker.podDisruptionBudget and provides an example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+27
| {{- if $hasMinAvailable }} | ||
| minAvailable: {{ $workerPdb.minAvailable }} | ||
| {{- else }} | ||
| maxUnavailable: {{ $workerPdb.maxUnavailable }} | ||
| {{- end }} |
Comment on lines
+681
to
+687
| * `worker.podDisruptionBudget` - object, default: `{}` | ||
|
|
||
| Worker [PodDisruptionBudget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) configuration. Configure one of the following options: `minAvailable` - minimum number of worker pods that must stay available. `maxUnavailable` - maximum number of worker pods that can be unavailable. | ||
| Example: | ||
| ```yaml | ||
| podDisruptionBudget: | ||
| minAvailable: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add worker PodDisruptionBudget support to the trino chart with configurable options under
worker.podDisruptionBudget.