Open
Conversation
Track active queries per panel and cancel in-flight queries when a new QueryData request arrives for the same panel (e.g. user changes filters or presses cancel). The context cancellation propagates through database/sql to the Trino driver, which sends a DELETE request to terminate the query on the Trino server. Fixes trinodb#310
laserninja
force-pushed
the
fix-cancel-query-grafana
branch
from
f5a0a63 to
b6e4dba
Compare
gertjanal
reviewed
Mar 22, 2026
| ctx, cancel := context.WithCancel(ctx) | ||
| defer cancel() | ||
|
|
||
| queryID := ds.queryCounter.Add(1) |
There was a problem hiding this comment.
Are race conditions possible here? Wouldn't it be better to create a random uuid for the queryID?
Contributor
Author
There was a problem hiding this comment.
Will bulk fix it ones someone/you does a through review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310