Fix NaN values handling in the progressPercentage property#13
Fix NaN values handling in the progressPercentage property#13stelmukhov wants to merge 3 commits intotrinodb:mainfrom
Conversation
| public long processedBytes { get; set; } | ||
| public long peakMemoryBytes { get; set; } | ||
| public long spilledBytes { get; set; } | ||
| public long progressPercentage { get; set; } |
There was a problem hiding this comment.
Separate commit .. and also why are you removing this?
There was a problem hiding this comment.
Since it's unused and there are other properties that are also missing here, I decided that the simplest fix is to remove it. However, I can also change its type to double, as defined here: QueryProgressStats.java#L34
There was a problem hiding this comment.
Hmm, I'm ok either way, do we know why it's unused in Java? Is this a Presto legacy? I'd keep it as it's optional until it's removed from the Java
stelmukhov
force-pushed
the
feature/nan-progress
branch
from
7f59008 to
0b09627
Compare
|
Hi @mosabua @georgewfisher , |
|
@martint can I get maintainer status here? :) |
5 participants
A simple fix for trino-csharp-client#12 since the
progressPercentageproperty is unused.Another option is to change the
progressPercentagetype fromlongtodouble,as it uses
OptionalDoublein Trino (QueryProgressStats.java#L34).Thanks