Open
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Reviewer's GuideThis PR refactors the TrinoBigDecimal type to explicitly track and preserve the numeric sign, overhaul the decimal-conversion logic with integrated precision checks, and expose utility getters, while cleaning up legacy conversion code and comments. Class diagram for updated TrinoBigDecimal structureclassDiagram
class TrinoBigDecimal {
- BigInteger integerPart
- BigInteger fractionalPart
- int scale
- int sign
+ TrinoBigDecimal(string value)
+ TrinoBigDecimal(BigInteger integerPart, BigInteger fractionalPart, int scale)
+ decimal ToDecimal()
+ int GetScale()
+ int GetPrecision()
+ int GetSign()
+ BigInteger GetIntegerPart()
+ BigInteger GetFractionalPart()
+ override string ToString()
+ override bool Equals(object obj)
+ override int GetHashCode()
- void Validate()
- static void AlignScales(ref TrinoBigDecimal a, ref TrinoBigDecimal b)
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `trino-csharp/Trino.Client/Types/BigDecimal.cs:22` </location>
<code_context>
+ value = value.Trim();
+
+ // Detect sign explicitly
+ sign = value.StartsWith("-", StringComparison.Ordinal) ? -1 : 1;
+ if (value.StartsWith("+") || value.StartsWith("-"))
+ value = value.Substring(1);
</code_context>
<issue_to_address>
**issue (bug_risk):** Sign detection logic may mishandle strings with multiple sign characters.
Please add validation to ensure only one leading sign character is allowed and the remainder of the string is numeric.
</issue_to_address>
### Comment 2
<location> `trino-csharp/Trino.Client/Types/BigDecimal.cs:27` </location>
<code_context>
+ value = value.Substring(1);
+
var parts = value.Split('.');
integerPart = BigInteger.Parse(parts[0]);
fractionalPart = parts.Length > 1 ? BigInteger.Parse(parts[1]) : BigInteger.Zero;
scale = parts.Length > 1 ? parts[1].Length : 0;
</code_context>
<issue_to_address>
**issue:** Parsing may throw if integer part is empty after sign removal.
For inputs like '-.123', parts[0] becomes an empty string, which will cause BigInteger.Parse to fail. Please handle cases where the integer part is missing by defaulting it to zero.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
I have signed the verification and returned back with ok. |
Member
stephen-zhao
left a comment
stephen-zhao
left a comment
There was a problem hiding this comment.
fyi, the maintainers haven't been active on this repo..
| public TrinoBigDecimal(BigInteger integerPart, BigInteger fractionalPart, int scale) | ||
| { | ||
| this.integerPart = integerPart; | ||
| sign = integerPart.Sign < 0 ? -1 : 1; |
Member
There was a problem hiding this comment.
Suggested change
| sign = integerPart.Sign < 0 ? -1 : 1; | |
| this.sign = integerPart.Sign < 0 ? -1 : 1; |
for style
Comment on lines
-10
to
-17
|
|
||
| /// <summary> | ||
| /// The scale represents the number of digits to the right of the decimal point. | ||
| /// It is used to determine the precision of the fractional part of the BigDecimal. | ||
| /// </summary> | ||
| /// <example> | ||
| /// For example, if the BigDecimal is "123.00456", the scale is 5 because there are five digits to the right of the decimal point, including the leading zeros. | ||
| /// </example> |
Member
There was a problem hiding this comment.
Can we add back all these comments? why remove them?
Member
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Preserve explicit sign in TrinoBigDecimal to correctly handle negative zero and improve decimal parsing, string conversion, equality, hashing, and conversion to decimal.
New Features:
Bug Fixes:
Enhancements: