Use orElseGet for lazy evaluation in RoutingTargetHandler#921
Closed
zeckem19 wants to merge 1 commit intotrinodb:mainfrom
Closed
Use orElseGet for lazy evaluation in RoutingTargetHandler#921zeckem19 wants to merge 1 commit intotrinodb:mainfrom
zeckem19 wants to merge 1 commit intotrinodb:mainfrom
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
ebyhr
reviewed
Feb 16, 2026
| new RoutingDestination(routingGroup, cluster, buildUriWithNewCluster(cluster, request), externalUrl), | ||
| request); | ||
| }).orElse(getRoutingTargetResponse(request)); | ||
| }).orElseGet(() -> getRoutingTargetResponse(request)); |
Member
There was a problem hiding this comment.
Is it possible to add a test? Let me know if the test is too complicated.
Author
|
Superseded by #922 which includes the same fix plus a test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #920
Description
RoutingTargetHandler.resolveRouting()usesOptional.orElse(getRoutingTargetResponse(request))which eagerly evaluates the fallback even when the query ID is found in the cache. If getRoutingTargetResponse() throws (e.g. no backends match the routing rules), the exception propagates and the request fails with a 500, despite the query ID being successfully resolved.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(X) Release notes are required, with the following suggested text:
Fix eager evaluation in RoutingTargetHandler
* Fix some things.