-
Notifications
You must be signed in to change notification settings - Fork 70
Ensure Query Cancellation on Context Deadline Expiry #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Query Cancellation on Context Deadline Expiry #140
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks, looks good otherwise. Thanks for working on this!
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@Flgado can you squash both commits? This is ready to be merged |
28cdd7e
to
2f5be5f
Compare
@nineinchnick done |
Problem description
Solution
This pull request addresses the issue by ensuring that the Close method is called when the context deadline is reached. This method will initiate a delete request, notifying Trino to cancel the corresponding underlying query. By adding this behavior, the query will be properly canceled when the context deadline expires, preventing unnecessary resource usage and improving the overall reliability of the system.