Improve Configuration Handling#32
Conversation
When running queries that do not exceed the expiration of the access token but are within the refresh grace period, make sure to remove the "Authorization" header from CURL before reauthenticating. It's still valid during the grace period, but we want to trigger a re-auth intentionally. Also fixed whitespace and PR workflow issues - growing pains from moving the project to public github.
Testing shows an approximate 25% improved query throughput with this enabled. 1 million rows per minute becomes 1.25 million rows per minute, give or take a few rows.
This fixes the build pipeline for the driver
I used the wrong version specification for WiX extensions. The fix was a one character change.
Use ISO 8601 compliant timestamp log prefixes so it's easier to tell when messages are written to the odbc log file.
Handle type code 2014 in SQLColumns - it appears to be a proprietary extension to trino that works with trino's JDBC driver. In the world of ODBC, the closest we can come is to a regular timestamp which is type code 93.
One feature blocking the ODBC driver from working on the Power BI Gateway server was that System DSNs were usable by anyone on the system, but the client secret decryption was only possible by the user who created the DSN. This meant that when the Power BI Gateway Server tried to use the DSN via its service account, the client secret could not be decrypted. With this commit in place, I have observed queries running via the Power BI Gateway server both for on-demand as well as scheduled data refreshes.
* Updated the old contributing.md inline with the trinodb organization * Update documentation to reference correct CONTRIBUTING.md
Remove reference to "organization", since the TSF org is now hosting this repo, but that is not the org it was meant to refer to.
* Better error reporting back to ODBC interface * Powershell installer for development ODBC driver. * Fix PR comment about port number <= 0 * PR comment to lowercase the file name. * Github PR tools required clang-format * Fix lint check. * Clean up compiler warning and fix an issue where the content would fail to decrypt. * Fix some compile issues.
Improve Configuration Handling
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
dprophet
force-pushed
the
ImproveConfigurationHandling
branch
from
14c4c50 to
d736b6f
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
2 participants
Improve Configuration Handling