Skip to content

Support Basic Authorization With UserName and Password #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dprophet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Basic Authorization With UserName and Password #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/driver/handles/connHandle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ void Connection::configure(DriverConfig config) {
config.getClientSecret(),
config.getOidcScope(),
config.getGrantType(),
config.getTokenEndpoint());
config.getTokenEndpoint(),
config.getAuthEndpoint(),
config.getUsername(),
config.getPassword(),
config.getOidcEndpointMethodEnum());
}

void Connection::setError(ErrorInfo errorInfo) {
Expand Down
3 changes: 2 additions & 1 deletion src/trinoAPIWrapper/apiAuthMethod.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ enum ApiAuthMethod {
AM_NO_AUTH = 0,
AM_EXTERNAL_AUTH = 1,
AM_CLIENT_CRED_AUTH = 2,
AM_DEVICE_FLOW = 3
AM_DEVICE_CODE = 3,

@rileymcdowell rileymcdowell Feb 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename from AM_DEVICE_FLOW to AM_DEVICE_CODE is causing compile errors for me. Looks like there are references to it in src/driver/config/driverConfig.cpp. I'm in favor of the rename, but you may need to include at least one more file in this PR to take care of the full rename.

AM_USERNAME_AND_PASSWORD = 4,
};
6 changes: 6 additions & 0 deletions src/trinoAPIWrapper/apiOidcMethod.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#pragma once

enum OidcEndpointMethod {
OEM_USER_INPUT = 0,
OEM_URL = 1,
};
Loading
Loading