-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Support for reading legacy date in Hive for Parquet #24611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcinsbd
wants to merge
4
commits into
trinodb:master
Choose a base branch
from
marcinsbd:marcinsbd/support-legacy-date
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
reviewed
Jan 3, 2025
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSource.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ColumnReaderFactory.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetReaderOptions.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/CalendarUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/CalendarUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/CalendarUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ColumnReaderFactory.java
Outdated
Show resolved
Hide resolved
73758d8
to
f425c41
Compare
f425c41
to
1d8213c
Compare
krvikash
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just skimmed
...rino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveSparkCompatibility.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetReaderOptions.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetReaderOptions.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetReaderOptions.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetReaderOptions.java
Outdated
Show resolved
Hide resolved
1d8213c
to
9c9f15b
Compare
Praveen2112
reviewed
Jan 16, 2025
...her/src/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeHive4Oss.java
Outdated
Show resolved
Hide resolved
...her/src/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeHive4Oss.java
Outdated
Show resolved
Hide resolved
...her/src/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeHive4Oss.java
Outdated
Show resolved
Hide resolved
...ain/resources/docker/trino-product-tests/conf/environment/singlenode-hive4-oss/hive-site.xml
Outdated
Show resolved
Hide resolved
...s/docker/trino-product-tests/conf/environment/singlenode-hive4-oss/tempto-configuration.yaml
Outdated
Show resolved
Hide resolved
lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/util/TestCalendarUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/util/TestCalendarUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/util/TestCalendarUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/util/CalendarUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/util/CalendarUtils.java
Outdated
Show resolved
Hide resolved
cac29f7
to
ca551e3
Compare
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
@raunaqmorarka ptal |
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
b4523cc
to
d69809c
Compare
d69809c
to
51ff833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#23904
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: