Test with JDK 25+16-ea-beta #25355
Draft
Test with JDK 25+16-ea-beta #25355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/jdk25-ea
branch
2 times, most recently
from
5c661b1 to
990c9d0
Compare
|
|
wendigo
force-pushed
the
serafin/jdk25-ea
branch
2 times, most recently
from
f463be3 to
29af6d5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Java version used by Trino’s runtime checks and CI configurations to test against a newer JDK early-access release.
- The required Java version in TrinoSystemRequirements is updated from "23" to "25-beta+14-ea".
- The CI workflows and setup action are updated to use "25-ea" as the default Java version for consistency.
Reviewed Changes
Copilot reviewed 3 out of 10 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java | Updated required Java version for runtime checks. |
| .github/workflows/ci.yml | Updated Java version references in workflow jobs. |
| .github/actions/setup/action.yml | Updated default Java version for setup action. |
Files not reviewed (7)
- core/jdk/current: Language not supported
- core/jdk/temurin/jdk-24+36/arm64: Language not supported
- core/jdk/temurin/jdk-24+36/ppc64le: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/amd64: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/arm64: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/ppc64le: Language not supported
- testing/trino-product-tests/pom.xml: Language not supported
Comments suppressed due to low confidence (2)
core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java:103
- The required Java version is set to "25-beta+14-ea", which differs in format from the "25-ea" used in other configurations. Please verify if this discrepancy is intentional or update the version strings for consistency.
Version required = Version.parse("25-beta+14-ea");
.github/workflows/ci.yml:190
- The java-version in this section is updated to '24', which may be inconsistent with the '25-ea' used elsewhere in the CI configuration. Consider updating it to '25-ea' for consistency.
java-version: '24'
29af6d5 to
6f6ba9d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project's Java version requirements to test with a newer JDK.
- Update the required Java version in TrinoSystemRequirements.java to "25-beta+14-ea".
- Modify the CI workflow and GitHub actions to use "25-ea" as the Java version.
Reviewed Changes
Copilot reviewed 3 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java | Updated minimum required Java version. |
| .github/workflows/ci.yml | Adjusted test matrix to use updated Java version settings. |
| .github/actions/setup/action.yml | Modified default Java version for setup. |
Files not reviewed (8)
- core/jdk/current: Language not supported
- core/jdk/temurin/jdk-24+36/arm64: Language not supported
- core/jdk/temurin/jdk-24+36/ppc64le: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/amd64: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/arm64: Language not supported
- core/jdk/temurin/jdk-25+14-ea-beta/ppc64le: Language not supported
- pom.xml: Language not supported
- testing/trino-product-tests/pom.xml: Language not supported
Comments suppressed due to low confidence (1)
core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java:103
- Ensure the required Java version string is consistent across the project. The SystemRequirements file uses "25-beta+14-ea", while the CI workflow and GitHub actions set the Java version to "25-ea".
Version required = Version.parse("25-beta+14-ea");
6f6ba9d to
0918302
Compare
wendigo
force-pushed
the
serafin/jdk25-ea
branch
from
0918302 to
d5b73bb
Compare
|
trino-main failing due to new timezone: https://github.com/openjdk/jdk/pull/24234/files (requires joda-time update to 2025b) |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: