Skip to content

Use Virtual Threads for both server and internal clients #25387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Mar 23, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 23, 2025
@sajjoseph
Copy link
Contributor

For a moment I thought it was meant for Trino clients. How about adjusting the title to indicate that it is for internal communication?

@wendigo
Copy link
Contributor Author

wendigo commented Mar 23, 2025

@sajjoseph we can't do that for clients yet but it's ok, majority of the traffic is internal communication

@starburstdata-automation
Copy link

starburstdata-automation commented Mar 24, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Mar 24, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: failure
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: Found regressions for:<br/>(presto/tpch, q21, duration, over by 13.0%)
Benchmark Comparison to the closest run from Master: Report

@wendigo
Copy link
Contributor Author

wendigo commented Mar 24, 2025

Throughput wise it looks good :)
CleanShot 2025-03-24 at 14 39 09@2x

@wendigo wendigo changed the title Use Virtual Threads for both server and clients Use Virtual Threads for both server and internal clients Mar 24, 2025
@wendigo
Copy link
Contributor Author

wendigo commented Mar 24, 2025

Iceberg looks good too:

CleanShot 2025-03-24 at 15 46 38@2x

@starburstdata-automation
Copy link

starburstdata-automation commented Mar 24, 2025

Started benchmark workflow for this PR with test type = hive/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: No baseline found.
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Mar 24, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: failure
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: Found regressions for:<br/>(presto/tpch, q21, duration, over by 24.2%)
Benchmark Comparison to the closest run from Master: Report

Copy link

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants